SPLAT-1293: Moved vSphereStaticIPs into Default from TechPreview#1729
SPLAT-1293: Moved vSphereStaticIPs into Default from TechPreview#1729openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @vr4manta! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/jira refresh |
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/assign @JoelSpeed |
|
Are there any E2E tests that we can run against this PR to ensure that the promotion is stable? Perhaps one of the payload informing/blocking CI jobs can test this feature? |
@JoelSpeed , Yes, I am updating CI to now have the flagged removed in 4.16+. Should be ready soon. |
|
/test ? |
|
@vr4manta: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-csi #1729 |
|
@vr4manta: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/18c950f0-ba0a-11ee-8ede-135b728b5892-0 |
openshift-merge-robot
added
the
needs-rebase
|
/retest |
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
added
size/L
|
@JoelSpeed , i need this one prior to the other two. I have to update installer PR to use this version of API and same with machine-api. The other two PRs are directly referencing my fork to pick up changes. |
|
@JoelSpeed After our talks today, this one is only needed before the installer. The machine-api-operator changes are independent. Are we good to approve the move of static ip for vsphere out of TechPreview? |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b349d80-cc0a-11ee-9ec6-58d17d440a2c-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b5b2020-cc2a-11ee-94e9-34a677c11ec2-0 |
|
@JoelSpeed , cluster-api changes look good: https://pr-payload-tests.ci.openshift.org/runs/ci/4b5b2020-cc2a-11ee-94e9-34a677c11ec2-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8b4cf8e0-ccd2-11ee-9ec5-3e170f3c0868-0 |
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3366d150-d56a-11ee-8cf3-3e103de02029-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4f84a730-d58e-11ee-971c-63a1a935b0ec-0 |
|
@JoelSpeed Other PRs are now merged. I'm ready to start reviewing this PR |
|
Tests look good, and the failure appears to be unrelated. Can see from artifacts that the IP address feature is working as expected and nodes have joined the cluster with static IPAM /lgtm |
openshift-ci
bot
added
lgtm
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vr4manta: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
SPLAT-1293
Changes
Blocking