-
Notifications
You must be signed in to change notification settings - Fork 584
Update machineCopnfig documentation for KernelType. #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @jbtrystram! Some important instructions when contributing to openshift/api: |
|
As per https://github.com/openshift/api#generating-crd-schemas , you would want to update type in https://github.com/openshift/api/blob/master/machineconfiguration/v1/types.go#L324 and run |
bd60d1d to
6dc52e7
Compare
|
@sinnykumari thanks for the advice, I went through those steps and updated the PR |
|
/lgtm |
|
For approval |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram, JoelSpeed, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jbtrystram: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
See openshift/machine-config-operator#3903