Skip to content

Conversation

@jbtrystram
Copy link
Contributor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

Hello @jbtrystram! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2023
@openshift-ci openshift-ci bot requested review from jkyros and sinnykumari October 10, 2023 09:28
@sinnykumari
Copy link

As per https://github.com/openshift/api#generating-crd-schemas , you would want to update type in https://github.com/openshift/api/blob/master/machineconfiguration/v1/types.go#L324 and run update-codegen-crds . @jkyros can help help better if I missed something.

@jbtrystram
Copy link
Contributor Author

@sinnykumari thanks for the advice, I went through those steps and updated the PR

@sinnykumari
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@sinnykumari
Copy link

For approval
/cc @JoelSpeed @deads2k

@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k October 10, 2023 19:40
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, JoelSpeed, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@jbtrystram: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit da29a70 into openshift:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants