Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

Related to openshift/enhancements#1479, this adds the API for the new OpenShiftControlPlane type that will be used to define how to bootstrap OpenShift clusters via Cluster API patterns.

This is part of an experiment and is yet to be proven, I will leave the PR as a draft until we are more confident in the approach we are building out.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2023
@JoelSpeed
Copy link
Contributor Author

/approve cancel

I do not want this to be accidentally merged

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jwforres for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@JoelSpeed
Copy link
Contributor Author

/test verify

@JoelSpeed JoelSpeed force-pushed the openshift-control-plane branch from fbb9599 to 583b004 Compare September 28, 2023 12:57
@JoelSpeed
Copy link
Contributor Author

/test verify

@JoelSpeed JoelSpeed force-pushed the openshift-control-plane branch from 583b004 to da79a0c Compare September 29, 2023 11:01
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview da79a0c link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-hypershift da79a0c link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial da79a0c link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn da79a0c link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview da79a0c link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-upgrade-minor da79a0c link true /test e2e-upgrade-minor
ci/prow/e2e-upgrade da79a0c link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

Not going to pursue this right now

@JoelSpeed JoelSpeed closed this Aug 9, 2024
@JoelSpeed JoelSpeed deleted the openshift-control-plane branch January 28, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants