Skip to content

Rename Infrastructure.CloudProvider to Platform #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jan 8, 2019
Merged

Rename Infrastructure.CloudProvider to Platform #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,31 @@ type InfrastructureSpec struct {
}

type InfrastructureStatus struct {
// cloudProvider is the IaaS provider that is running the cluster.
//
// Valid values are:
// - aws
// - openstack
// +optional
CloudProvider string `json:"cloudProvider,omitempty"`
// platform is the underlying infrastructure provider for the cluster. This
// value controls whether infrastructure automation such as service load
// balancers, dynamic volume provisioning, machine creation and deletion, and
// other integrations are enabled. If None, no infrastructure automation is
// enabled.
Platform PlatformType `json:"platform,omitempty"`
}

// platformType is a specific supported infrastructure provider.
type PlatformType string

const (
// awsPlatform represents Amazon AWS.
AWSPlatform PlatformType = "AWS"

// openStackPlatform represents OpenStack.
OpenStackPlatform PlatformType = "OpenStack"

Copy link
Contributor

@abhinavdahiya abhinavdahiya Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add libvirt too? We already at least have machine management

Copy link
Contributor Author

@ironcladlou ironcladlou Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// libvirtPlatform represents libvirt.
LibvirtPlatform PlatformType = "Libvirt"

// nonePlatform means there is no infrastructure provider.
NonePlatform PlatformType = "None"
)

// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

type InfrastructureList struct {
Expand Down