OCPBUGS-8356: config/v1/types_cluster_version: Make update architecture omitempty

[wking]

Avoid a cosmetic:

Warning: unknown field "spec.desiredUpdate.architecture"

when a 4.13 or later oc adm upgrade --to ... or similar talks to a 4.12 or earlier ClusterVersion. Before this commit, oc would format a patch body that included an explicit "architecture": "", which the 4.12 ClusterVersion didn't understand. With this change, oc will leave the architecture field unset unless it actually has architecture opinions.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-8356, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Avoid a cosmetic:

Warning: unknown field "spec.desiredUpdate.architecture"

when a 4.13 or later oc adm upgrade --to ... or similar talks to a 4.12 or earlier ClusterVersion. Before this commit, oc would format a patch body that included an explicit "architecture": "", which the 4.12 ClusterVersion didn't understand. With this change, oc will leave the architecture field unset unless it actually has architecture opinions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hello @wking! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[wking]

/jira refresh

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-8356, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

Server-side apply in the command sounds like a better solution.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-ci]

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-8356, which is invalid:

• expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Avoid a cosmetic:

Warning: unknown field "spec.desiredUpdate.architecture"

when a 4.13 or later oc adm upgrade --to ... or similar talks to a 4.12 or earlier ClusterVersion. Before this commit, oc would format a patch body that included an explicit "architecture": "", which the 4.12 ClusterVersion didn't understand. With this change, oc will leave the architecture field unset unless it actually has architecture opinions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-8356, which is invalid:

• expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Avoid a cosmetic:

Warning: unknown field "spec.desiredUpdate.architecture"

when a 4.13 or later oc adm upgrade --to ... or similar talks to a 4.12 or earlier ClusterVersion. Before this commit, oc would format a patch body that included an explicit "architecture": "", which the 4.12 ClusterVersion didn't understand. With this change, oc will leave the architecture field unset unless it actually has architecture opinions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-8356. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Avoid a cosmetic:

Warning: unknown field "spec.desiredUpdate.architecture"

when a 4.13 or later oc adm upgrade --to ... or similar talks to a 4.12 or earlier ClusterVersion. Before this commit, oc would format a patch body that included an explicit "architecture": "", which the 4.12 ClusterVersion didn't understand. With this change, oc will leave the architecture field unset unless it actually has architecture opinions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.