OCPBUGS-11729: VSphereStorageDriver does not document the platform default

[dobsonj]

https://issues.redhat.com/browse/OCPBUGS-11729
This also disables setting LegacyDeprecatedInTreeDriver in 4.14. That setting is only valid in 4.13. Integration tests are updated accordingly, since this caused any test case using that setting to fail.
/cc @JoelSpeed

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-11729, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-11729
This also disables setting LegacyDeprecatedInTreeDriver in 4.14. That setting is only valid in 4.13. Integration tests are updated accordingly, since this caused any test case using that setting to fail.
/cc @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hello @dobsonj! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[dobsonj]

/jira help

[dobsonj]

/cherry-pick help

[openshift-cherrypick-robot]

@dobsonj: once the present PR merges, I will cherry-pick it on top of help in a new PR and assign it to you.

Details

In response to this:

/cherry-pick help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/cherry-pick cancel
I just want the jira ticket created, not a PR opened.

[openshift-cherrypick-robot]

@dobsonj: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cancel
I just want the jira ticket created, not a PR opened.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

lol I give up

[dobsonj]

/jira refresh

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-11729, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/jira refresh

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-11729, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/lgtm
/approve

Thanks

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dobsonj: Jira Issue OCPBUGS-11729: All pull requests linked via external trackers have merged:

• openshift/api#1440

Jira Issue OCPBUGS-11729 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-11729
This also disables setting LegacyDeprecatedInTreeDriver in 4.14. That setting is only valid in 4.13. Integration tests are updated accordingly, since this caused any test case using that setting to fail.
/cc @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@dobsonj: cannot checkout cancel: error checking out cancel: exit status 1. output: error: pathspec 'cancel' did not match any file(s) known to git

Details

In response to this:

/cherry-pick cancel
I just want the jira ticket created, not a PR opened.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@dobsonj: cannot checkout help: error checking out help: exit status 1. output: error: pathspec 'help' did not match any file(s) known to git

Details

In response to this:

/cherry-pick help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.