Skip to content

OCPBUGS-11493: Update storage vSphere driver validation#1435

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:fix-storage-driver-validation
Apr 6, 2023
Merged

OCPBUGS-11493: Update storage vSphere driver validation#1435
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:fix-storage-driver-validation

Conversation

@JoelSpeed
Copy link
Contributor

We need to be able to switch between LegacyDeprecatedInTreeDriver and "" so this updates the validation to relax it so that we can do so.
I've simplified based on what I believe the intention is, allowing changing to CSIWithMigraitonDriver, but not allowing changing away from it, so once oldSelf is CSIMigration driver, self must be too

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@JoelSpeed
Copy link
Contributor Author

CC @jsafrane @dobsonj

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 6, 2023
@openshift-ci openshift-ci bot requested review from adambkaplan and jwforres April 6, 2023 13:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Apr 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ce21e3f into openshift:master Apr 6, 2023
@JoelSpeed JoelSpeed changed the title Update storage vSphere driver validation OCPBUGS-11493: Update storage vSphere driver validation Apr 6, 2023
@openshift-ci-robot
Copy link

@JoelSpeed: Jira Issue OCPBUGS-11493: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11493 has been moved to the MODIFIED state.

Details

In response to this:

We need to be able to switch between LegacyDeprecatedInTreeDriver and "" so this updates the validation to relax it so that we can do so.
I've simplified based on what I believe the intention is, allowing changing to CSIWithMigraitonDriver, but not allowing changing away from it, so once oldSelf is CSIMigration driver, self must be too

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@JoelSpeed: new pull request created: #1437

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants