Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 23, 2022

ComponentRoutes are keyed by namespace,name tuples. See the docs on the field here: https://kubernetes.io/docs/reference/using-api/server-side-apply/#merge-strategy

Not sure what to do about HSTS, that may be an evolutionary problem.

/assign @Miciah @JoelSpeed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@deads2k
Copy link
Contributor Author

deads2k commented Aug 23, 2022

I think we'll need #1262 before merging this one.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@JoelSpeed
Copy link
Contributor

Needs an update-codegen-crds but otherwise LGTM

@deads2k deads2k force-pushed the apply-03-ingress-route-status branch from c13df19 to a9dae0f Compare August 24, 2022 12:50
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 24, 2022
@deads2k
Copy link
Contributor Author

deads2k commented Aug 24, 2022

Needs an update-codegen-crds but otherwise LGTM

Done, labelled.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0f86a22 into openshift:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants