-
Notifications
You must be signed in to change notification settings - Fork 581
update ingress component route SSA list markers #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ingress component route SSA list markers #1262
Conversation
|
Hello @deads2k! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
|
I think we'll need #1262 before merging this one. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Needs an |
c13df19 to
a9dae0f
Compare
Done, labelled. |
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ComponentRoutes are keyed by namespace,name tuples. See the docs on the field here: https://kubernetes.io/docs/reference/using-api/server-side-apply/#merge-strategy
Not sure what to do about HSTS, that may be an evolutionary problem.
/assign @Miciah @JoelSpeed