Skip to content

Conversation

@tylerslaton
Copy link

@tylerslaton tylerslaton commented Jul 21, 2022

Summary

Adding the necassary API's for PlatformOperators as outlined by this EP. This is a work in progress PR that is meant to burn down on review while the EP finishes up and is thus subject to change as progress is made. This PR is now ready for review.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

Hello @tylerslaton! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@openshift-ci openshift-ci bot requested review from adambkaplan and knobunc July 21, 2022 17:10
@tylerslaton
Copy link
Author

/test all

@tylerslaton
Copy link
Author

/test all

@timflannagan
Copy link
Contributor

@tylerslaton Once we get the CRD generation working, we need to ensure that the release.openshift.io/feature-gate: "TechPreviewNoUpgrade" k/v annotation is present on that manifest.

@tylerslaton
Copy link
Author

/retest

@tylerslaton tylerslaton force-pushed the add-po-api branch 2 times, most recently from 3d07a64 to 898e2e6 Compare July 22, 2022 15:59
@tylerslaton
Copy link
Author

/retest

@tylerslaton tylerslaton force-pushed the add-po-api branch 2 times, most recently from c34bc08 to 849179b Compare July 22, 2022 18:10
@tylerslaton tylerslaton marked this pull request as ready for review July 22, 2022 18:11
@tylerslaton tylerslaton changed the title [WIP] feat(platform): introduce Platform API at v1alpha1 level feat(platform): introduce Platform API at v1alpha1 level Jul 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2022
@openshift-ci openshift-ci bot requested a review from bparees July 22, 2022 18:12
@tylerslaton tylerslaton force-pushed the add-po-api branch 3 times, most recently from 4d43e0e to 5739b51 Compare July 22, 2022 19:02
@timflannagan
Copy link
Contributor

cc @joelanford

@joelanford
Copy link
Member

In case it isn't clear, it should be noted that the EP for platform operators dictates that the PlatformOperator.metadata.name is the only input necessary for reconciliation, for now at least.

That value will be interpreted as the package name that the controller should lookup and attempt to source bundles from.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@timflannagan
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@timflannagan
Copy link
Contributor

Wow crazy timing.

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2022
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2022

@tylerslaton: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@tylerslaton
Copy link
Author

@jianzhangbjz @michaelryanpeter Would you mind taking a look and giving the QE/Doc tags here?

@deads2k
Copy link
Contributor

deads2k commented Aug 26, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@jianzhangbjz
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 30, 2022
@adellape
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 30, 2022
@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 81fadf1 into openshift:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants