CONSOLE-3221: Add console capability #1232

raspbeep · 2022-07-21T10:34:18Z

Introduces the console as a new capability and adds new versioned capability set for the current version of OCP.

https://issues.redhat.com/browse/CONSOLE-3221

Link to PR introducing to console-operator manifests: openshift/console-operator#665

Signed-off-by: Pavel Kratochvil <[email protected]>

openshift-ci · 2022-07-21T10:35:36Z

Hello @raspbeep! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label command.

Who should apply these qe/docs/px labels?

For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

openshift-ci · 2022-07-21T10:35:39Z

Hi @raspbeep. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

raspbeep · 2022-07-25T11:18:02Z

Hi @sttts @eparis, could you review this one please?

jhadvig

/lgtm
/hold

Could you create a PR for adding the annotation to the console-operator repo?

@bparees to confirm our actions. We need:

merge api change (this) PR
vendor the api change into the cvo repo
merge change that introduces new annotation in the console-operator
vendor api changes into the installer repo

jhadvig · 2022-07-25T14:56:17Z

/ok-to-test

jhadvig · 2022-07-25T14:56:24Z

/approve

bparees · 2022-07-25T19:32:16Z

@jhadvig https://github.com/openshift/enhancements/blob/master/enhancements/installer/component-selection.md#how-to-implement-a-new-capability has the latest guidance/steps

Signed-off-by: Pavel Kratochvil <[email protected]>

jhadvig · 2022-07-27T15:17:27Z

QE Approver:
 /assign @yapei
Docs Approver:
 /assign @opayne1
PX Approver:
/assign @RickJWagner

jhadvig · 2022-07-27T15:20:03Z

/retitle CONSOLE-3221: Add console capability

opayne1 · 2022-07-27T15:23:46Z

/label docs-approved

RickJWagner · 2022-07-27T15:25:00Z

/label px-approved

Signed-off-by: Pavel Kratochvil <[email protected]>

yanpzhan · 2022-07-29T03:13:59Z

@raspbeep @jhadvig Hi, could you pls tell me for QE how to test this pr?

jhadvig · 2022-07-29T14:44:18Z

/label tide/merge-method-squash

yanpzhan · 2022-08-01T00:28:54Z

/label qe-approved

yanpzhan · 2022-08-01T01:41:06Z

Since we could not test console capability feature against this pr directly, will test the feature after this pr/related pr merged.

jhadvig · 2022-08-01T07:30:09Z

/lgtm

raspbeep · 2022-08-01T08:41:18Z

/assign @soltysh
We need to merge this API change first to be able to test this PR.

soltysh

/approve

openshift-ci · 2022-08-01T11:25:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, raspbeep, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jhadvig · 2022-08-01T12:19:10Z

/hold cancel

openshift-ci · 2022-08-01T12:40:56Z

@raspbeep: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The lowercase form just landed via 9db3a0c (CONSOLE-3221: Add console capability (openshift#1232), 2022-08-01), and that matched the lower-case precedent which we had been using for these enumerated capabilities. But the Kube-API preference is for PascalCase [1], so this commit pivots to that form. Because we are so close on the heels of the original change, we don't need to preserve any references to the outgoing form. Adjusting the 4.11 references like openshift-samples will take more dancing, and can happen in follow-up work. Generated with: $ sed -i 's|$capability[.]openshift[.]io/name$: console|\1: Console|' $(git grep -l 'capability.openshift.io/name: console') $ sed -i 's/console/Console/' config/v1/*version* And then backing out one godocs hit that the above made: $ sed -i 's/the web Console/the web console/' config/v1/*version* [1]: https://github.com/openshift/enhancements/blame/b3f5408be4505e37c0bdb7f8b2630a92a5d01457/dev-guide/api-conventions.md#L195

* Add console capability Signed-off-by: Pavel Kratochvil <[email protected]> * Add version entry for v4.12 and its capabilities Signed-off-by: Pavel Kratochvil <[email protected]> * make verify Signed-off-by: Pavel Kratochvil <[email protected]> * Add console capability annotation to CRDs Signed-off-by: Pavel Kratochvil <[email protected]> Co-authored-by: Pavel Kratochvil <[email protected]>

Pavel Kratochvil added 2 commits July 21, 2022 12:15

Add console capability

7f20083

Signed-off-by: Pavel Kratochvil <[email protected]>

Add version entry for v4.12 and its capabilities

7395174

Signed-off-by: Pavel Kratochvil <[email protected]>

openshift-ci bot requested review from eparis and sttts July 21, 2022 10:35

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2022

jhadvig approved these changes Jul 25, 2022

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2022

openshift-ci bot assigned jhadvig Jul 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022

make verify

9067714

Signed-off-by: Pavel Kratochvil <[email protected]>

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022

openshift-ci bot changed the title ~~Add console capability~~ CONSOLE-3221: Add console capability Jul 27, 2022

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 27, 2022

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 27, 2022

jhadvig mentioned this pull request Jul 28, 2022

CONSOLE-3220: Add console capability to all manifests openshift/console-operator#665

Merged

Add console capability annotation to CRDs

1c3504d

Signed-off-by: Pavel Kratochvil <[email protected]>

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 29, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 1, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022

openshift-ci bot assigned soltysh Aug 1, 2022

soltysh approved these changes Aug 1, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022

openshift-merge-robot merged commit 9db3a0c into openshift:master Aug 1, 2022

wking mentioned this pull request Aug 1, 2022

config/v1: Change ClusterVersion capability from 'console' to 'Console' #1240

Merged

CONSOLE-3221: Add console capability #1232

CONSOLE-3221: Add console capability #1232

Uh oh!

Conversation

raspbeep commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jul 21, 2022

Uh oh!

openshift-ci bot commented Jul 21, 2022

Uh oh!

raspbeep commented Jul 25, 2022

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

jhadvig commented Jul 25, 2022

Uh oh!

jhadvig commented Jul 25, 2022

Uh oh!

bparees commented Jul 25, 2022

Uh oh!

jhadvig commented Jul 27, 2022

Uh oh!

jhadvig commented Jul 27, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opayne1 commented Jul 27, 2022

Uh oh!

RickJWagner commented Jul 27, 2022

Uh oh!

yanpzhan commented Jul 29, 2022

Uh oh!

jhadvig commented Jul 29, 2022

Uh oh!

yanpzhan commented Aug 1, 2022

Uh oh!

yanpzhan commented Aug 1, 2022

Uh oh!

jhadvig commented Aug 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raspbeep commented Aug 1, 2022

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Aug 1, 2022

Uh oh!

jhadvig commented Aug 1, 2022

Uh oh!

openshift-ci bot commented Aug 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

raspbeep commented Jul 21, 2022 •

edited

Loading

jhadvig commented Jul 27, 2022 •

edited by openshift-ci bot

Loading

jhadvig commented Aug 1, 2022 •

edited

Loading