types/ingress: add new tuning option: maxConnections #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frobware
force-pushed
the
haproxy-maxconn
branch
2 times, most recently
from
b0e336e to
3cab877
Compare
Miciah
reviewed
Apr 6, 2022
operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml
Outdated
Show resolved
Hide resolved
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 7, 2022
Switch from the unsupported config override to the tuning option introduced in openshift/api#1161.
Miciah
reviewed
Apr 11, 2022
gcs278
reviewed
Apr 12, 2022
Contributor
gcs278
left a comment
gcs278
left a comment
There was a problem hiding this comment.
Reviewed and updates look good to me. Will let others lgtm.
frobware
force-pushed
the
haproxy-maxconn
branch
2 times, most recently
from
7cc4481 to
5ed19fc
Compare
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 14, 2022
Switch from the unsupported config override to the tuning option introduced in openshift/api#1161.
frobware
force-pushed
the
haproxy-maxconn
branch
from
5ed19fc to
d927d92
Compare
deads2k
reviewed
Apr 21, 2022
Contributor
|
The API itself looks ok, but I'd like to understand how the operator will ensure the pods can function. I expected to see something like, "the operator may choose to increase memory requests to cover higher values". Not a specific promise of how or how much, but an indication that the operator will make adjustments |
frobware
force-pushed
the
haproxy-maxconn
branch
from
d927d92 to
46280bf
Compare
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 21, 2022
Switch from the unsupported config override to the tuning option introduced in openshift/api#1161.
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 25, 2022
Switch from the unsupported config override to the tuning option introduced in openshift/api#1161.
frobware
force-pushed
the
haproxy-maxconn
branch
from
46280bf to
a98c1c6
Compare
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 27, 2022
Switch from the unsupported config override to the tuning option introduced in openshift/api#1161.
frobware
force-pushed
the
haproxy-maxconn
branch
from
a98c1c6 to
0c7ae02
Compare
frobware
added a commit
to frobware/enhancements
that referenced
this pull request
Apr 27, 2022
frobware
force-pushed
the
haproxy-maxconn
branch
2 times, most recently
from
e323cdd to
60d1090
Compare
Adds a new field to the IngressController API to allow the maximum number of simultaneous connections (i.e., maxconn) be configurable by cluster administrators: openshift/enhancements#1084
frobware
force-pushed
the
haproxy-maxconn
branch
from
60d1090 to
4d31f71
Compare
Contributor
|
@frobware: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
frobware
added a commit
to frobware/enhancements
that referenced
this pull request
Apr 28, 2022
Contributor
|
looks great. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, frobware The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
Member
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 29, 2022
$ go get github.com/openshift/api@1469fac35c7515f007526e51f519eef7339a1bbb $ go mod vendor $ go mod tidy
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 29, 2022
Switch from the unsupported config override to the tuning option introduced in openshift/api#1161.
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
Apr 29, 2022
$ go get github.com/openshift/api@1469fac35c7515f007526e51f519eef7339a1bbb $ go mod vendor $ go mod tidy
frobware
added a commit
to frobware/cluster-ingress-operator
that referenced
this pull request
May 9, 2022
$ go get github.com/openshift/api@1469fac35c7515f007526e51f519eef7339a1bbb $ go mod vendor $ go mod tidy
thejasn
pushed a commit
to thejasn/enhancements
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field to the IngressController API to allow the maximum
number of simultaneous connections (i.e., maxconn) be configurable by
cluster administrators:
openshift/enhancements#1084