Machine API: adding Alibaba cloud provider types. #1045
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package v1 | ||
|
|
||
| // InstanceTenancy indicates if instance should run on shared or single-tenant hardware. | ||
| type InstanceTenancy string | ||
|
|
||
| const ( | ||
| // DefaultTenancy instance runs on shared hardware | ||
| DefaultTenancy InstanceTenancy = "default" | ||
| // DedicatedTenancy instance runs on single-tenant hardware | ||
| DedicatedTenancy InstanceTenancy = "dedicated" | ||
| // HostTenancy instance runs on a Dedicated Host, which is an isolated server with configurations that you can control. | ||
| HostTenancy InstanceTenancy = "host" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // +k8s:deepcopy-gen=package,register | ||
| // +k8s:defaulter-gen=TypeMeta | ||
| // +k8s:openapi-gen=true | ||
|
|
||
| // +kubebuilder:validation:Optional | ||
| // +groupName=machine.openshift.io | ||
| package v1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package v1 | ||
|
|
||
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| ) | ||
|
|
||
| var ( | ||
| GroupName = "machine.openshift.io" | ||
| GroupVersion = schema.GroupVersion{Group: GroupName, Version: "v1"} | ||
| schemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) | ||
| // Install is a function which adds this version to a scheme | ||
| Install = schemeBuilder.AddToScheme | ||
| ) | ||
|
|
||
| // Adds the list of known types to api.Scheme. | ||
| func addKnownTypes(scheme *runtime.Scheme) error { | ||
| metav1.AddToGroupVersion(scheme, GroupVersion) | ||
|
|
||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,342 @@ | ||
| /* | ||
| Copyright 2021 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1 | ||
|
|
||
| import ( | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| // AlibabaDiskPerformanceLevel enum attribute to describe a disk's performance level | ||
| type AlibabaDiskPerformanceLevel string | ||
|
|
||
| // AlibabaDiskCatagory enum attribute to deescribe a disk's category | ||
| type AlibabaDiskCategory string | ||
|
|
||
| // AlibabaDiskEncryptionMode enum attribute to describe whether to enable or disable disk encryption | ||
| type AlibabaDiskEncryptionMode string | ||
|
|
||
| // AlibabaDiskPreservationPolicy enum attribute to describe whether to preserve or delete a disk upon instance removal | ||
| type AlibabaDiskPreservationPolicy string | ||
|
|
||
| const ( | ||
| // DeleteWithInstance enum property to delete disk with instance deletion | ||
| DeleteWithInstance AlibabaDiskPreservationPolicy = "DeleteWithInstance" | ||
| // PreserveDisk enum property to determine disk preservation with instance deletion | ||
| PreserveDisk AlibabaDiskPreservationPolicy = "PreserveDisk" | ||
|
|
||
| // AlibabaDiskEncryptionEnabled enum property to enable disk encryption | ||
| AlibabaDiskEncryptionEnabled AlibabaDiskEncryptionMode = "encrypted" | ||
| // AlibabaDiskEncryptionDisabled enum property to disable disk encryption | ||
| AlibabaDiskEncryptionDisabled AlibabaDiskEncryptionMode = "disabled" | ||
|
|
||
| // AlibabaDiskPerformanceLevel0 enum property to set the level at PL0 | ||
| PL0 AlibabaDiskPerformanceLevel = "PL0" | ||
| // AlibabaDiskPerformanceLevel1 enum property to set the level at PL1 | ||
| PL1 AlibabaDiskPerformanceLevel = "PL1" | ||
| // AlibabaDiskPerformanceLevel2 enum property to set the level at PL2 | ||
| PL2 AlibabaDiskPerformanceLevel = "PL2" | ||
| // AlibabaDiskPerformanceLevel3 enum property to set the level at PL3 | ||
| PL3 AlibabaDiskPerformanceLevel = "PL3" | ||
|
|
||
| // AlibabaDiskCategoryUltraDisk enum proprty to set the category of disk to ultra disk | ||
| AlibabaDiskCatagoryUltraDisk AlibabaDiskCategory = "cloud_efficiency" | ||
| // AlibabaDiskCategorySSD enum proprty to set the category of disk to standard SSD | ||
| AlibabaDiskCatagorySSD AlibabaDiskCategory = "cloud_ssd" | ||
| // AlibabaDiskCategoryESSD enum proprty to set the category of disk to ESSD | ||
| AlibabaDiskCatagoryESSD AlibabaDiskCategory = "cloud_essd" | ||
| // AlibabaDiskCategoryBasic enum proprty to set the category of disk to basic | ||
| AlibabaDiskCatagoryBasic AlibabaDiskCategory = "cloud" | ||
| ) | ||
|
|
||
| // +genclient | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| // AlibabaCloudMachineProviderConfig is the Schema for the alibabacloudmachineproviderconfig API | ||
| // Compatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer). | ||
| // +openshift:compatibility-gen:level=1 | ||
| // +k8s:openapi-gen=true | ||
| type AlibabaCloudMachineProviderConfig struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
|
||
| // More detail about alibabacloud ECS | ||
| // https://www.alibabacloud.com/help/doc-detail/25499.htm?spm=a2c63.l28256.b99.727.496d7453jF7Moz | ||
|
|
||
| //The instance type of the instance. | ||
| InstanceType string `json:"instanceType"` | ||
|
|
||
| // The ID of the vpc | ||
|
Contributor
There was a problem hiding this comment. describe what happens if
Author
There was a problem hiding this comment. The VpcID is used to query and then match the machines. If this information is not included it is left empty. Here is a current machineset: The VpcID is not included and therefore when queries are run they are excluded. The end result is that the instance is found by the tags, region, and other metadata. This is just one piece of metadata that could be used to search for the instance. |
||
| // +optional | ||
| VpcID string `json:"vpcId,omitempty"` | ||
|
|
||
| // The ID of the region in which to create the instance. You can call the DescribeRegions operation to query the most recent region list. | ||
| RegionID string `json:"regionId"` | ||
|
|
||
| // The ID of the zone in which to create the instance. You can call the DescribeZones operation to query the most recent region list. | ||
| ZoneID string `json:"zoneId"` | ||
|
|
||
| // The ID of the image used to create the instance. | ||
| ImageID string `json:"imageId"` | ||
|
|
||
| // DataDisks holds information regarding the extra disks attached to the instance | ||
| // +optional | ||
| DataDisks []DataDiskProperties `json:"dataDisk,omitempty"` | ||
|
|
||
| // SecurityGroups is a list of security group references to assign to the instance. A reference holds either the security group ID | ||
| // or the required tags to search. The limit of N values varies based on the maximum number of security groups to which an instance can belong. | ||
| // For more information, see the "Security group limits" section in Limits. | ||
| // https://www.alibabacloud.com/help/doc-detail/101348.htm?spm=a2c63.p38356.879954.48.78f0199aX3dfIE | ||
| SecurityGroups []AlibabaResourceReference `json:"securityGroups,omitempty"` | ||
|
|
||
| // Bandwidth describes the internet bandwidth strategy for the instance | ||
| // +optional | ||
| Bandwidth BandwidthProperties `json:"bandwidth,omitempty"` | ||
|
|
||
| // SystemDisk holds the properties regarding the system disk for the instance | ||
| // +optional | ||
| SystemDisk SystemDiskProperties `json:"systemDisk,omitempty"` | ||
|
|
||
| // VSwitch is a reference to the vswitch to use for this instance | ||
| // This parameter is required when you create an instance of the VPC type. | ||
| // You can call the DescribeVSwitches operation to query the created vSwitches. | ||
| VSwitch AlibabaResourceReference `json:"vSwitch,omitempty"` | ||
|
|
||
| // RAMRoleName is the name of the instance Resource Access Management (RAM) role. This allows the instance to perform API calls as this specified RAM role. | ||
| // +optional | ||
| RAMRoleName string `json:"ramRoleName,omitempty"` | ||
|
|
||
| // ResourceGroupID is the unique ID of the resource group to which to assign the instance. | ||
| // +optional | ||
| ResourceGroupID string `json:"resourceGroupId,omitempty"` | ||
|
|
||
| // Tenancy specifies whether to create the instance on a dedicated host. | ||
| // Valid values: | ||
| // | ||
| // default: creates the instance on a non-dedicated host. | ||
| // host: creates the instance on a dedicated host. If you do not specify the DedicatedHostID parameter, Alibaba Cloud automatically selects a dedicated host for the instance. | ||
| // Empty value means no opinion and the platform chooses the a default, which is subject to change over time. | ||
| // Currently the default is `default`. | ||
| // +optional | ||
| Tenancy InstanceTenancy `json:"tenancy,omitempty"` | ||
|
|
||
| // UserDataSecret contains a local reference to a secret that contains the | ||
| // UserData to apply to the instance | ||
| // +optional | ||
| UserDataSecret *corev1.LocalObjectReference `json:"userDataSecret,omitempty"` | ||
|
|
||
| // CredentialsSecret is a reference to the secret with alibabacloud credentials. Otherwise, defaults to permissions | ||
| // provided by attached RAM role where the actuator is running. | ||
| // +optional | ||
| CredentialsSecret *corev1.LocalObjectReference `json:"credentialsSecret,omitempty"` | ||
|
|
||
| // Tags are the set of metadata to add to an instance. | ||
| // +optional | ||
| Tags []Tag `json:"tag,omitempty"` | ||
| } | ||
|
|
||
| // ResourceTagReference is a reference to a specific AlibabaCloud resource by ID, or tags. | ||
| // Only one of ID or Tags may be specified. Specifying more than one will result in | ||
| // a validation error. | ||
| type AlibabaResourceReference struct { | ||
| // ID of resource | ||
| // +optional | ||
|
Contributor
There was a problem hiding this comment. this is used in spec, how can ID be empty in spec?
Author
There was a problem hiding this comment. This is similar to the AWS provider field. This can either hold an ID to an AlibabaResourceReference or this struct holds the necessary tags that can be used to search for the resource. (e.g. securityGroups. Note, no ID but tags required to find the resource ID). |
||
| ID string `json:"id,omitempty"` | ||
|
|
||
| // Tags is a set of metadata based upon ECS object tags used to identify a resource | ||
|
Contributor
There was a problem hiding this comment. what if more than one matches?
Author
There was a problem hiding this comment. This depends on the resource. For the securitygroup types, there might be one to many security groups per instance. For the vSwitch property, the first one in the results is returned. |
||
| // +optional | ||
| Tags []Tag `json:"tags,omitempty"` | ||
| } | ||
|
|
||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| // AlibabaCloudMachineProviderConfigList contains a list of AlibabaCloudMachineProviderConfig | ||
| // Compatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer). | ||
| // +openshift:compatibility-gen:level=1 | ||
| type AlibabaCloudMachineProviderConfigList struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ListMeta `json:"metadata,omitempty"` | ||
| Items []AlibabaCloudMachineProviderConfig `json:"items"` | ||
| } | ||
|
|
||
| // AlibabaCloudMachineProviderStatus is the Schema for the alibabacloudmachineproviderconfig API | ||
| // Compatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer). | ||
| // +openshift:compatibility-gen:level=1 | ||
| //+k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
| type AlibabaCloudMachineProviderStatus struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
|
||
| // InstanceID is the instance ID of the machine created in alibabacloud | ||
| // +optional | ||
| InstanceID *string `json:"instanceId,omitempty"` | ||
|
|
||
| // InstanceState is the state of the alibabacloud instance for this machine | ||
| // +optional | ||
| InstanceState *string `json:"instanceState,omitempty"` | ||
|
|
||
| // Conditions is a set of conditions associated with the Machine to indicate | ||
| // errors or other status | ||
| // +optional | ||
| Conditions []metav1.Condition `json:"conditions,omitempty"` | ||
| } | ||
|
|
||
| // SystemDiskProperties contains the information regarding the system disk including performance, size, name, and category | ||
| type SystemDiskProperties struct { | ||
| // Category is the category of the system disk. | ||
| // Valid values: | ||
| // cloud_essd: ESSD. When the parameter is set to this value, you can use the SystemDisk.PerformanceLevel parameter to specify the performance level of the disk. | ||
| // cloud_efficiency: ultra disk. | ||
| // cloud_ssd: standard SSD. | ||
| // cloud: basic disk. | ||
| // Empty value means no opinion and the platform chooses the a default, which is subject to change over time. | ||
| // Currently for non-I/O optimized instances of retired instance types, the default is `cloud`. | ||
| // Currently for other instances, the default is `cloud_efficiency`. | ||
| // +kubebuilder:validation:Enum="cloud_efficiency"; "cloud_ssd"; "cloud_essd"; "cloud" | ||
| // +optional | ||
| Category string `json:"category,omitempty"` | ||
|
|
||
| // PerformanceLevel is the performance level of the ESSD used as the system disk. | ||
| // Valid values: | ||
| // | ||
| // PL0: A single ESSD can deliver up to 10,000 random read/write IOPS. | ||
| // PL1: A single ESSD can deliver up to 50,000 random read/write IOPS. | ||
| // PL2: A single ESSD can deliver up to 100,000 random read/write IOPS. | ||
| // PL3: A single ESSD can deliver up to 1,000,000 random read/write IOPS. | ||
| // Empty value means no opinion and the platform chooses a default, which is subject to change over time. | ||
| // Currently the default is `PL1`. | ||
| // For more information about ESSD performance levels, see ESSDs. | ||
| // +kubebuilder:validation:Enum="PL0"; "PL1"; "PL2"; "PL3" | ||
| // +optional | ||
| PerformanceLevel string `json:"performanceLevel,omitempty"` | ||
|
|
||
| // Name is the name of the system disk. If the name is specified the name must be 2 to 128 characters in length. It must start with a letter and cannot start with http:// or https://. It can contain letters, digits, colons (:), underscores (_), and hyphens (-). | ||
| // Empty value means the platform chooses a default, which is subject to change over time. | ||
| // Currently the default is `""`. | ||
| // +kubebuilder:validation:MaxLength=128 | ||
| // +optional | ||
| Name string `json:"name,omitempty"` | ||
|
|
||
| // Size is the size of the system disk. Unit: GiB. Valid values: 20 to 500. | ||
| // The value must be at least 20 and greater than or equal to the size of the image. | ||
| // Empty value means the platform chooses a default, which is subject to change over time. | ||
| // Currently the default is `40` or the size of the image depending on whichever is greater. | ||
| // +optional | ||
| Size int64 `json:"size,omitempty"` | ||
| } | ||
|
|
||
| // DataDisk contains the information regarding the datadisk attached to an instance | ||
| type DataDiskProperties struct { | ||
| // Name is the name of data disk N. If the name is specified the name must be 2 to 128 characters in length. It must start with a letter and cannot start with http:// or https://. It can contain letters, digits, colons (:), underscores (_), and hyphens (-). | ||
| // | ||
| // Empty value means the platform chooses a default, which is subject to change over time. | ||
| // Currently the default is `""`. | ||
| // +optional | ||
| Name string `name:"diskName,omitempty"` | ||
|
|
||
| // SnapshotID is the ID of the snapshot used to create data disk N. Valid values of N: 1 to 16. | ||
| // | ||
| // When the DataDisk.N.SnapshotID parameter is specified, the DataDisk.N.Size parameter is ignored. The data disk is created based on the size of the specified snapshot. | ||
| // Use snapshots created after July 15, 2013. Otherwise, an error is returned and your request is rejected. | ||
| // | ||
| // +optional | ||
| SnapshotID string `name:"snapshotId,omitempty"` | ||
|
|
||
| // Size of the data disk N. Valid values of N: 1 to 16. Unit: GiB. Valid values: | ||
| // | ||
| // Valid values when DataDisk.N.Category is set to cloud_efficiency: 20 to 32768 | ||
| // Valid values when DataDisk.N.Category is set to cloud_ssd: 20 to 32768 | ||
| // Valid values when DataDisk.N.Category is set to cloud_essd: 20 to 32768 | ||
| // Valid values when DataDisk.N.Category is set to cloud: 5 to 2000 | ||
| // The value of this parameter must be greater than or equal to the size of the snapshot specified by the SnapshotID parameter. | ||
| // +optional | ||
| Size int64 `name:"size,omitempty"` | ||
|
|
||
| // DiskEncryption specifies whether to encrypt data disk N. | ||
| // | ||
| // Empty value means the platform chooses a default, which is subject to change over time. | ||
| // Currently the default is `disabled`. | ||
| // +kubebuilder:validation:Enum="encrypted";"disabled" | ||
| // +optional | ||
| DiskEncryption AlibabaDiskEncryptionMode `name:"diskEncryption,omitempty"` | ||
|
|
||
| // PerformanceLevel is the performance level of the ESSD used as as data disk N. The N value must be the same as that in DataDisk.N.Category when DataDisk.N.Category is set to cloud_essd. | ||
| // Empty value means no opinion and the platform chooses a default, which is subject to change over time. | ||
| // Currently the default is `PL1`. | ||
| // Valid values: | ||
| // | ||
| // PL0: A single ESSD can deliver up to 10,000 random read/write IOPS. | ||
| // PL1: A single ESSD can deliver up to 50,000 random read/write IOPS. | ||
| // PL2: A single ESSD can deliver up to 100,000 random read/write IOPS. | ||
| // PL3: A single ESSD can deliver up to 1,000,000 random read/write IOPS. | ||
| // For more information about ESSD performance levels, see ESSDs. | ||
| // +kubebuilder:validation:Enum="PL0"; "PL1"; "PL2"; "PL3" | ||
| // +optional | ||
| PerformanceLevel AlibabaDiskPerformanceLevel `name:"performanceLevel,omitempty"` | ||
|
|
||
| // Category describes the type of data disk N. | ||
| // Valid values: | ||
| // cloud_efficiency: ultra disk | ||
| // cloud_ssd: standard SSD | ||
| // cloud_essd: ESSD | ||
| // cloud: basic disk | ||
| // Empty value means no opinion and the platform chooses the a default, which is subject to change over time. | ||
| // Currently for non-I/O optimized instances of retired instance types, the default is `cloud`. | ||
| // Currently for other instances, the default is `cloud_efficiency`. | ||
| // +kubebuilder:validation:Enum="cloud_efficiency"; "cloud_ssd"; "cloud_essd"; "cloud" | ||
| // +optional | ||
| Category AlibabaDiskCategory `name:"category,omitempty"` | ||
|
|
||
| // KMSKeyID is the ID of the Key Management Service (KMS) key to be used by data disk N. | ||
| // Empty value means no opinion and the platform chooses the a default, which is subject to change over time. | ||
| // Currently the default is `""` which is interpreted as do not use KMSKey encryption. | ||
| // +optional | ||
| KMSKeyID string `name:"kmsKeyId,omitempty"` | ||
|
|
||
| // DiskPreservation specifies whether to release data disk N along with the instance. | ||
| // Empty value means no opinion and the platform chooses the a default, which is subject to change over time. | ||
| // Currently the default is `DeleteWithInstance` | ||
| // +kubebuilder:validation:Enum="DeleteWithInstance";"PreserveDisk" | ||
| // +optional | ||
| DiskPreservation AlibabaDiskPreservationPolicy `name:"diskPreservation,omitempty"` | ||
| } | ||
|
|
||
| // Tag The tags of ECS Instance | ||
| type Tag struct { | ||
| // Key is the name of the key pair | ||
| Key string `name:"Key"` | ||
| // Value is the value or data of the key pair | ||
| Value string `name:"value"` | ||
| } | ||
|
|
||
| // Bandwidth describes the bandwidth strategy for the network of the instance | ||
| type BandwidthProperties struct { | ||
| // InternetMaxBandwidthIn is the maximum inbound public bandwidth. Unit: Mbit/s. Valid values: | ||
| // When the purchased outbound public bandwidth is less than or equal to 10 Mbit/s, the valid values of this parameter are 1 to 10. | ||
| // Currently the default is `10` when outbound bandwidth is less than or equal to 10 Mbit/s. | ||
| // When the purchased outbound public bandwidth is greater than 10, the valid values are 1 to the InternetMaxBandwidthOut value. | ||
| // Currently the default is the value used for `InternetMaxBandwidthOut` when outbound public bandwidth is greater than 10. | ||
| // +optional | ||
| InternetMaxBandwidthIn int64 `json:"internetMaxBandwidthIn,omitempty"` | ||
|
|
||
| // InternetMaxBandwidthOut is the maximum outbound public bandwidth. Unit: Mbit/s. Valid values: 0 to 100. | ||
| // When a value greater than 0 is used then a public IP address is assigned to the instance. | ||
| // Empty value means no opinion and the platform chooses the a default, which is subject to change over time. | ||
| // Currently the default is `0` | ||
|
Contributor
There was a problem hiding this comment. by default we disallow egress traffic?
Author
There was a problem hiding this comment. The documentation here is lacking. I looked up this information during the latst review but was unable to find something more concrete. According to the docs https://www.alibabacloud.com/help/doc-detail/25499.htm it states Another explanation states the following (https://partners-intl.aliyun.com/help/doc-detail/51198.html?spm=a3c0i.10721930.0.0.783e3d98N6R3k4) I will ask Alibaba to clarify what the default behavior is on this. There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
This is the content of a ROS example template. This is just the default value of this parameter, just like the default in Terraform's variables.
Contributor
There was a problem hiding this comment. Why would I want to set a value that is not maximal for this? If I want an assigned egress IP, why would I limit the traffic? Is it for cost reasons? |
||
| // +optional | ||
| InternetMaxBandwidthOut int64 `json:"internetMaxBandwidthOut,omitempty"` | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something i am confused/concerned about with our migration of provider specs to the openshift/api is that it seems like these types will now have different api groups than they previously had. eg, AWS in 4.9 would have been
awsproviderconfig.openshift.io, but will now bemachine.openshift.io. i presume that this alibaba provider config will have themachine.openshift.iogroup?@JoelSpeed @alexander-demichev , i don't remember this coming up during our discussions of the api move, but i also admit this point is highly nuanced so i might have missed the detail back then. is there perhaps a kubebuilder annotation that we can add to adjust the group for these things? or maybe we should put the provider specs in the proper directory path in this repo? (i'm not sure the best solution)
given that we have these embedded api types documented at specific groups in our documentation already, i'm really curious how much of an issue this is. it seems like a big deal, but i might be missing something about our api types. i looked back at the discussion in #1005 when the provider specs were added but i didn't see any discussion there. what do you think?
also, fwiw, i realize these provider types won't necessarily be hitting the kubernetes api server in the same way as other objects. but i'm still highly curious ;)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we discussed this issue during our team standup today. the team feels that the change of group for these types is extremely low risk. these objects do not persist in the kuberenetes api server beyond being data in raw extensions, and as such are not being used as kubernetes objects in the manner we would expect of an object like a Machine.
we will update the product docs to indicate the changes that will be seen by users when creating MachineSets from our examples. but just to note, the group values listed in our examples do not impact user functionality.