AGENT-1552: Add lvms-operator to config

[bfournie]

Include lvms-operator in the list of included operator images. Now that storage operators are removed as CNV dependencies in openshift/assisted-service#10541 including the images allows them to be optionally included.

Summary by CodeRabbit

• New Features
  • Added an additional operator package entry to the appliance configuration.
  • Enabled the lvms-operator to be included and configured to follow the stable-4.21 channel.
  • This applies to both the 5.0 and 4.23 appliance configurations.

[openshift-ci-robot]

@bfournie: This pull request references AGENT-1552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Include lvms-operator in the list of included operator images. Now that storage operators are removed as CNV dependencies in openshift/assisted-service#10541 including the images allows them to be optionally included.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 305a2855-12b9-4b99-97a5-dba93f1dd76a

📥 Commits

Reviewing files that changed from the base of the PR and between d4caf44 and f8e1e70.

📒 Files selected for processing (2)

• tools/iso_builder/config/4.23/appliance-config.yaml
• tools/iso_builder/config/5.0/appliance-config.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• tools/iso_builder/config/4.23/appliance-config.yaml
• tools/iso_builder/config/5.0/appliance-config.yaml

---

Walkthrough

Added lvms-operator package entries to the appliance configs for 4.23 and 5.0, both set to the stable-4.21 channel.

Changes

ISO builder appliance operator config

Layer / File(s)	Summary
Add lvms-operator entry tools/iso_builder/config/4.23/appliance-config.yaml, tools/iso_builder/config/5.0/appliance-config.yaml	Adds lvms-operator to the operators package list in both appliance configs with channels set to stable-4.21.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately summarizes the main change: adding lvms-operator to the configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only two appliance-config YAML files changed; no Ginkgo tests or test titles were added or modified.
Test Structure And Quality	✅ Passed	PR only updates YAML appliance configs; no Ginkgo test files or test logic changed, so this test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only appliance-config YAML changed; no Ginkgo/e2e tests or OpenShift API usage were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only changes appliance config YAML, so there are no SNO multi-node assumptions to flag.
Topology-Aware Scheduling Compatibility	✅ Passed	Change only adds lvms-operator package entries in appliance-config YAML; no replicas, affinity, nodeSelectors, tolerations, or topology logic were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only adds lvms-operator entries in YAML configs; no process-level code, suite setup, or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only appliance-config YAML changed; no new Ginkgo e2e tests or network assumptions were added.
No-Weak-Crypto	✅ Passed	Only YAML operator lists changed; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/comparison code appears in the touched files.
Container-Privileges	✅ Passed	The PR only adds lvms-operator package entries to appliance-config YAML; no privileged/root/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds lvms-operator entries to two YAML configs; no logging code or sensitive fields (passwords, tokens, PII, secrets) were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bfournie]

/test e2e-agent-compact-ipv4-iso-no-registry

[pawanpinjarkar]

/lgtm

[bfournie]

/verified by @bfournie

[openshift-ci-robot]

@bfournie: This PR has been marked as verified by @bfournie.

Details

In response to this:

/verified by @bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bfournie: This pull request references AGENT-1552 which is a valid jira issue.

Details

In response to this:

Include lvms-operator in the list of included operator images. Now that storage operators are removed as CNV dependencies in openshift/assisted-service#10541 including the images allows them to be optionally included.

Summary by CodeRabbit

• New Features
• Added an additional operator package entry to the appliance configuration.
• Enabled the lvms-operator to be included and configured to follow the stable-4.21 channel.
• This applies to both the 5.0 and 4.23 appliance configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/verified by 'kflux-prd-rh02 / Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request'

[openshift-ci-robot]

@bfournie: This PR has been marked as verified by 'kflux-prd-rh02 / Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request'.

Details

In response to this:

/verified by 'kflux-prd-rh02 / Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/test ?

[andfasano]

/test e2e-agent-compact-ipv4-iso-no-registry

Let's check for a green run before landing this patch

[openshift-ci]

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[andfasano]

/lgtm