[release-3.3] use ossm charts for 1.28.4#701
Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift-service-mesh:release-3.3from Mar 9, 2026
Merged
Conversation
Signed-off-by: Cameron Garrison <cgarriso@redhat.com>
cam-garrison
changed the title
Signed-off-by: Cameron Garrison <cgarriso@redhat.com>
Signed-off-by: Cameron Garrison <cgarriso@redhat.com>
FilipB
requested changes
Mar 4, 2026
| {{ end }} | ||
| {{ if (isset .ObjectMeta.Annotations `sidecar.istio.io/proxyMemory`) -}} | ||
| memory: {{ index .ObjectMeta.Annotations `sidecar.istio.io/proxyMemory` | quote }} | ||
| memory: "{{ index .ObjectMeta.Annotations `sidecar.istio.io/proxyMemory` }}" |
There was a problem hiding this comment.
This should not be here. It seems we have not yet synced mesh/istio repo with upstream istio 1.27.7
cam-garrison
changed the title
FilipB
approved these changes
Mar 4, 2026
Author
|
/test ocp-4.20-e2e-ocp-arm |
|
/retest |
openshift-merge-bot
bot
merged commit 02e48ff
into
openshift-service-mesh:release-3.3
9 checks passed
|
@cam-garrison: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dcillera
pushed a commit
to dcillera/sail-operator
that referenced
this pull request
Mar 19, 2026
…mesh#701) We don't support migrating `IstioCNI` to another namespace, so we should make the field immutable for now. We already did it for the spec.namespace field of the `Istio` resource. Once we implement support for namespace migrations of these resources, we can revert this. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
dcillera
pushed a commit
to dcillera/sail-operator
that referenced
this pull request
Mar 19, 2026
* upstream/release-1.0: make spec.namespace field of `IstioCNI` immutable (openshift-service-mesh#701) pin version of setup-envtest (openshift-service-mesh#703)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.