Added more code validation checkts to CI

[bkhadars]

No description provided.

[clnperez]

i'm not sure, but i'm guessing that the issue you saw might be worked around by putting quotes around this expression or something to that effect. did you try any other ways to format this?

[clnperez]

any updates? you'd mentioned you were going to look at removing the validate vendor check

[bkhadars]

@clnperez update the change, commented vendor check for now

[clnperez]

You may need to pull in the latest upstream to get these checks to pass. I just tried re-running them and no-go.

[clnperez]

@bkhadars any way you can get this in soon? i'm kind of waiting on it before we check in too many other PRs so we can have these checks.

[bkhadars]

Raised PR for verifying codegen script, I think that PR should fix the issue

[clnperez]

I think you have to rebase one more time to pick up the codegen fixes.

[clnperez]

@bkhadars ping

[bkhadars]

@clnperez I have rebased the code to latest, but the checks are still failing as go vet list errors from the platform validation testcases... We should fix those platform validation test cases..

I have commented out those testcases for time being and raised the New PR with the other vet changes

[bkhadars]

@clnperez I have rebased the changes and vet is failing as the vendor changes are required...

[clnperez]

the codegen test exits with errors but doesn't fail the check:

+ go generate ./pkg/types/installconfig.go
github.com/openshift/installer/pkg/types:-: conflicting types in allOf branches in schema: string vs DiskCategory
github.com/openshift/installer/pkg/types:-: conflicting types in allOf branches in schema: string vs DiskCategory
github.com/openshift/installer/pkg/types:-: conflicting types in allOf branches in schema: string vs DiskCategory
Error: not all generators ran successfully
run `controller-gen crd:crdVersions=v1 paths=. output:dir=../../data/data/ -w` to see all available markers, or `controller-gen crd:crdVersions=v1 paths=. output:dir=../../data/data/ -h` for usage
exit status 1
pkg/types/installconfig.go:70: running "go": exit status 1
+ go generate ./pkg/rhcos/ami.go

and it should be in its own job like the rest.

and vet is failing as the vendor changes are required...

If we check in all the vendor changes this ups our likelihood for merge conflicts exponentially. We just can't check in those since we pull in upstream changes all the time. If you need the vendored files to be there just do what is done for the build, and run go mod vendor first before running the go vet. You could even combine those two tests to shorten the time of the checks.

[clnperez]

looks like the codegen issue is actually a problem with the test itself (see openshift#5406 (comment)) so we can leave that bit as-is

[clnperez]

in trying to understand what was going on with your PR I ended up just creating my own b/c that was the only way to test it, so, we can just close this one. thanks for the other fixes and getting this started!