Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository name breaking for bb cloud when it's not in url slug form #1781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riddler7
Copy link

Changes

The repository name field provided by the Bitbucket Cloud webhook is the raw name of the repository in Bitbucket and can contain characters such as spaces. When this is combined with the organisation to generate the url for the repository it subsequently breaks. This PR uses the full_name field for the repository which is properly formatted.

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

@savitaashture
Copy link
Member

/test

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.18%. Comparing base (a10162c) to head (aab839b).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
+ Coverage   65.16%   65.18%   +0.02%     
==========================================
  Files         174      174              
  Lines       13250    13252       +2     
==========================================
+ Hits         8634     8638       +4     
+ Misses       4043     4041       -2     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riddler7 riddler7 force-pushed the fix-bitbucket-cloud-repo-name branch from aab839b to ac23d8c Compare November 7, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants