Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github UI on ok-to-test comment event #1733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zakisk
Copy link
Contributor

@zakisk zakisk commented Jul 4, 2024

This will allow repository owner to make a PR ready to test by sending ok-to-test comment event and update Github UI accordingly when there is no matching Pipelinerun in .tekton directory.

SRVKP-4345

This will allow repository owner to make a PR ready to
test by sending ok-to-test comment event and update
Github UI accordingly when there is no matching Pipelinerun
in .tekton directory.

https://issues.redhat.com/browse/SRVKP-4345

Signed-off-by: Zaki Shaikh <[email protected]>
@chmouel
Copy link
Member

chmouel commented Jul 4, 2024

this code is security sensitive let's make sure to review this thoroughly

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 64.56%. Comparing base (be424e4) to head (41cf947).

Files Patch % Lines
pkg/pipelineascode/match.go 0.00% 12 Missing and 1 partial ⚠️
pkg/matcher/annotation_matcher.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   64.63%   64.56%   -0.08%     
==========================================
  Files         146      146              
  Lines       11264    11284      +20     
==========================================
+ Hits         7281     7285       +4     
- Misses       3452     3466      +14     
- Partials      531      533       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants