PLNSRVCE-1692: overhaul taskrun controller deadlocked to work of same taskrun flagged on consecutive scans; add similar metric for pipelinerun controller #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabemontero
changed the title
|
/hold |
|
closing out in favor of a new PR off the same branch |
|
I though git would allow that but it doesn't ... reopening / rewording |
gabemontero
changed the title
gabemontero
changed the title
gabemontero
force-pushed
the
deadlock-stat-handle-pending
branch
2 times, most recently
from
4526319 to
2483899
Compare
…d on consecutive scans; add similar metric for pipelinerun controller finally caught a rash of pendings live and realized that while the amount of pendings oscillated, it was not the same taskruns, so created new metric for taskruns, and then a similar one for pipelineruns did not add a name label, but the controller's cache which is reset on each scan tracks specific runs also made reason/message check more flexible, allow either to be set and added env var based filter specification to rule out konflux development namespaces which are more likely to have erroneous, unanticipated TaskRun construction issues rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
gabemontero
force-pushed
the
deadlock-stat-handle-pending
branch
from
2483899 to
62fbf30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally caught a rash of pendings live and realized that while the amount of pendings oscillated, it was not the same taskruns,
so created new metric for taskruns, and then a similar one for pipelineruns
did not add a name label, but the controller's cache which is reset on each scan tracks specific runs
also made reason/message check more flexible, allow either to be set
and added env var based filter specification to rule out konflux development namespaces which are more likely to have erroneous, unanticipated TaskRun construction issues
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@enarha @jkhelil fyi / ptal
@savitaashture - a peek into the "too soon to upstream" type of metrics I'm building for Konflux to satisfy app sre level SLI/SLA wrt metrics, alerts, docs
Once I fee really good about metrics in this component, I try to move them to tektoncd/pipelines