Skip to content

Conversation

@vikram-raj
Copy link
Member

Descriptions: Remove the react-router 5.x dependency from Pipeline console plugin as the console team is planning to drop React Router 5 support for dynamic plugins

Components that were replaced:

  • Replace { history } >> const params = useNavigate();
  • Replace { location } >> const location = useLocation();
  • Now import Link from react-router-dom-v5-compat
  • Remove RouterComponentProps instead of it use hooks useParams to get the params.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 24, 2025

@vikram-raj: This pull request references ODC-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Descriptions: Remove the react-router 5.x dependency from Pipeline console plugin as the console team is planning to drop React Router 5 support for dynamic plugins

Components that were replaced:

  • Replace { history } >> const params = useNavigate();
  • Replace { location } >> const location = useLocation();
  • Now import Link from react-router-dom-v5-compat
  • Remove RouterComponentProps instead of it use hooks useParams to get the params.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj vikram-raj requested review from lokanandaprabhu and removed request for Lucifergene April 24, 2025 06:34
Copy link
Member

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lokanandaprabhu,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj
Copy link
Member Author

/retest

@vikram-raj vikram-raj merged commit 9bc6e24 into openshift-pipelines:main May 6, 2025
4 of 7 checks passed
@vikram-raj vikram-raj deleted the odc-7789 branch May 6, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants