Skip to content

NO-JIRA: fix start-console.sh for MAC #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vikram-raj wants to merge 1 commit into from
Closed

NO-JIRA: fix start-console.sh for MAC #335

vikram-raj wants to merge 1 commit into from

Conversation

@vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Mar 25, 2025

No description provided.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 25, 2025

@vikram-raj: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj
Copy link
Member Author

vikram-raj commented Mar 25, 2025

/cc @lokanandaprabhu

@vikram-raj vikram-raj changed the title NO-JIRA: fix start-console.sh NO-JIRA: fix start-console.sh for MAC Mar 25, 2025
lokanandaprabhu
lokanandaprabhu reviewed Mar 26, 2025
View reviewed changes
start-console.sh
CONSOLE_IMAGE_PLATFORM=${CONSOLE_IMAGE_PLATFORM:="linux/amd64"}

# Plugin metadata is declared in package.json
PLUGIN_NAME=${npm_package_consolePlugin_name}
Copy link
Member

@lokanandaprabhu lokanandaprabhu Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting below error when I run the script

./start-console.sh: line 10: npm_package_consolePlugin_name: unbound variable

@vikram-raj vikram-raj closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokanandaprabhu lokanandaprabhu lokanandaprabhu left review comments

@saumeya saumeya Awaiting requested review from saumeya

Assignees

No one assigned

Labels

approved jira/valid-reference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikram-raj @openshift-ci-robot @lokanandaprabhu