OCM-6450 | No update cluster with empty config

ocm edit will update always the cluster even there is no new configuration. This commit checks the configuration before make the update call. Signed-off-by: Alba Hita Catala <[email protected]>
openshift-online · Mar 1, 2024 · 9cf11ef · 9cf11ef
1 parent 1095264
commit 9cf11ef
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/cmd/ocm/edit/cluster/cmd.go b/cmd/ocm/edit/cluster/cmd.go
@@ -16,6 +16,7 @@ package cluster
 import (
 	"fmt"
 	"os"
+	"reflect"
 	"strings"
 	"time"
 
@@ -268,9 +269,11 @@ func run(cmd *cobra.Command, argv []string) error {
 	}
 	clusterConfig.ClusterWideProxy = clusterWideProxy
 
-	err = c.UpdateCluster(clusterCollection, cluster.ID(), clusterConfig)
-	if err != nil {
-		return fmt.Errorf("Failed to update cluster: %v", err)
+	if !reflect.ValueOf(clusterConfig).IsZero() {
+		err = c.UpdateCluster(clusterCollection, cluster.ID(), clusterConfig)
+		if err != nil {
+			return fmt.Errorf("Failed to update cluster: %v", err)
+		}
 	}
 
 	return nil