using info as default log level #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @clyang82 |
skeeey
force-pushed
the
log
branch
2 times, most recently
from
cb4c3c1 to
22ae793
Compare
clyang82
reviewed
Oct 20, 2025
| viper.SetConfigFile(logConfigFile) | ||
| // default log level is info | ||
| viper.SetDefault(varLogLevel, "info") | ||
| logger.SetLogLevel("info") |
There was a problem hiding this comment.
I think it is related with #268. we allow to modify the log level in runtime.
There was a problem hiding this comment.
yes, we still allow to modify the log level in runtime, but we should not use viper.SetDefault to set default log level, it does not work
Signed-off-by: Wei Liu <[email protected]>
|
Please reply in the thread to tell SRE to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-v=2as default log level for klog in sdk-go (🌱 using context log open-cluster-management-io/sdk-go#151)We only log the request metadata in these log levels