fix(control-plane): use FQDN for sandbox-injected service URLs - #465
Closed
JuanmaBM wants to merge 1 commit into
Closed
fix(control-plane): use FQDN for sandbox-injected service URLs#465JuanmaBM wants to merge 1 commit into
JuanmaBM wants to merge 1 commit into
Conversation
The ndots:1 workaround for OpenShell musl DNS (NVIDIA/OpenShell#2053) causes .svc short names to fail resolution inside sandbox pods. With ndots:1, hostnames with 1+ dots are tried as absolute names first — ambient-control-plane.<ns>.svc is not a valid FQDN and fails. Use .svc.cluster.local in CP_TOKEN_URL manifests and remove redundant .svc endpoints from the sandbox network policy, keeping only the FQDN variants that resolve correctly regardless of ndots setting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.svc.cluster.localFQDN inCP_TOKEN_URLacross all deployment manifests.svc(non-FQDN) endpoints from sandbox network policy insandbox_policy.goProblem
The
ndots:1workaround for NVIDIA/OpenShell#2053 (musl libc DNS bug, fix proposed in PR #2054) causes.svcshort names to fail DNS resolution inside sandbox pods. Withndots:1, hostnames with 1+ dots are tried as absolute names first —ambient-control-plane.<ns>.svcis not a valid FQDN and fails with:With the default
ndots:5, the same name (3 dots < 5) would have search domains appended first, resolving correctly. The FQDN.svc.cluster.localresolves correctly regardless ofndotssetting.Test plan
CP_TOKEN_URL.svc.cluster.localis the standard Kubernetes FQDN)🤖 Generated with Claude Code