Add user_data_url_headers#46
Merged
Merged
Conversation
Author
|
I think we'll need this to make openshift/installer#4359 work (I'm working on an update to that which I'll push when working e2e) |
stbenjam
requested changes
Nov 28, 2020
stbenjam
left a comment
stbenjam
left a comment
Member
There was a problem hiding this comment.
One small thing but otherwise lgtm
hardys
force-pushed
the
url_fixes
branch
2 times, most recently
from
6f866e3 to
d47c796
Compare
When retrieving user_data_url from some sources it's necessary to include headers to get the desired result, in particular when reading data from the MCS on OpenShift it's necessary to include "Accept: application/vnd.coreos.ignition+json; version=3.1.0" Otherwise the GET returns a 2.2.0 config which isn't compatible with the latest OS images. More info here: https://github.com/openshift/machine-config-operator/blob/master/docs/HACKING.md#accessing-the-machineconfigserver-directly
hardys
force-pushed
the
url_fixes
branch
6 times, most recently
from
ffb2309 to
278e157
Compare
kirankt
approved these changes
Nov 30, 2020
hardys
force-pushed
the
url_fixes
branch
2 times, most recently
from
2bcc6c5 to
c243578
Compare
hardys
pushed a commit
to hardys/installer
that referenced
this pull request
Dec 2, 2020
This restores the work which was previously done via openshift#3276 but then reverted via openshift#3589 due to breaking users who customized the pointer ignition config in IPI deployments. A solution to that has been proposed via openshift#4413 - see openshift/enhancements#540 for more details. Note that some additional changes beyond the initial implementation were required due to the MCO now supporting multiple ignition versions, thus this depends on openshift-metal3/terraform-provider-ironic#46 Co-Authored-By: Steven Hardy <shardy@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When retrieving user_data_url from some sources it's necessary to include headers to get the desired result, in particular when
reading data from the MCS on OpenShift it's necessary to include
Otherwise the GET returns a 2.2.0 config which isn't compatible with the latest OS images.
https://github.com/openshift/machine-config-operator/blob/master/docs/HACKING.md#accessing-the-machineconfigserver-directly
Also adjusted the error handling so it's clearer if there's a problem retrieving the config as previously this was silently ignored.