Support for sending full ignition to masters

[kirankt]

Continuing the work of @hardys in #37 .

This PR adds support for https cert disabling and retries.

[kirankt]

Looks like CI is failing. Do we need to bump CI's go version to 1.13?

[stbenjam]

Looks good to me, a couple questions.

Could we add a test?

https://github.com/openshift-metal3/terraform-provider-ironic/blob/master/ironic/resource_ironic_deployment_test.go

[kirankt]

Looks good to me, a couple questions.

Could we add a test?

https://github.com/openshift-metal3/terraform-provider-ironic/blob/master/ironic/resource_ironic_deployment_test.go

Absolutely. Will work on it.

[kirankt]

@stbenjam Please take a look at the new changes. I have removed user-data field because we're not going to pass it from the installer side anymore.

[stbenjam]

@stbenjam Please take a look at the new changes. I have removed user-data field because we're not going to pass it from the installer side anymore.

It doesn't look like it's fully removed, but I think it should probably stay as an option anyway. OpenShift may not be the only user of this, and I'd like to not break them. It can be exclusive, make sure user_data or the URL are set, but not both.

[kirankt]

@stbenjam Please take a look at the new changes. I have removed user-data field because we're not going to pass it from the installer side anymore.

It doesn't look like it's fully removed, but I think it should probably stay as an option anyway. OpenShift may not be the only user of this, and I'd like to not break them. It can be exclusive, make sure user_data or the URL are set, but not both.

I just retained what we did earlier. Give user_data_url higher priority when both are specified. if there is an error getting data from user_data_url, we fall back to user_data.

[stbenjam]

LGTM, thanks