This repository was archived by the owner on Jul 23, 2019. It is now read-only.
Change name of Machine labels.#80
Merged
stbenjam merged 1 commit intoopenshift-metal3:masterfrom May 16, 2019
Merged
Conversation
Member
russellb
commented
May 16, 2019
russellb
commented
Member
Author
|
This PR is on top of PR #75 |
4 tasks
7 tasks
openshift/installer changed the Machine label names in commit be7bf8e. The newest openshift/cluster-api code validates Machine objects against this updated label as well, causing the failure seen here: openshift-metal3/dev-scripts#537 (comment)
russellb
force-pushed
the
machine-api-change
branch
from
7e77c3d to
d9a232e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.