This repository was archived by the owner on Jul 23, 2019. It is now read-only.
Add api-int record to bootstrap#77
Merged
stbenjam merged 1 commit intoopenshift-metal3:masterfrom May 16, 2019
Merged
Conversation
Add the hosts plugin to coredns so that we can create a static entry for api-int.$CLUSTER_DOMAIN. hosts is used because it doesn't have to be authoritative for the zone and can allow fallthrough of records that are not found.
Contributor
Author
|
@celebdor This should get api-int working on the bootstrap node too. |
stbenjam
approved these changes
May 13, 2019
Member
stbenjam
left a comment
stbenjam
left a comment
There was a problem hiding this comment.
Master nodes do get their ignition successfully with this change.
Collaborator
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/632/ |
stbenjam
suggested changes
May 13, 2019
Member
stbenjam
left a comment
stbenjam
left a comment
There was a problem hiding this comment.
D'oh, sorry - I had my change from this morning still applied - openshift-metal3/dev-scripts#531 :-(
With just this, it's not enough. Ignition hosts aren't pointing at coredns, they're all hitting 192.168.111.1, which doesn't have the api-int record.
7 tasks
Member
|
I added the temporary record to openshift-metal3/dev-scripts#523. I suppose we still need this as well, for when after the cluster comes up. |
stbenjam
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the hosts plugin to coredns so that we can create a static entry
for api-int.$CLUSTER_DOMAIN. hosts is used because it doesn't have to
be authoritative for the zone and can allow fallthrough of records
that are not found.