This repository was archived by the owner on Jul 23, 2019. It is now read-only.
Add a Dockerfile for building an installer binary image#53
Merged
russellb merged 1 commit intoopenshift-metal3:masterfrom Apr 24, 2019
Merged
Add a Dockerfile for building an installer binary image#53russellb merged 1 commit intoopenshift-metal3:masterfrom
russellb merged 1 commit intoopenshift-metal3:masterfrom
Conversation
This is just a variant of images/installer/Dockerfile.ci that builds an image with kni-install at /usr/bin/openshift-install - this is so 'oc adm release extract --tools' knows how to extact it. We also install libvirt-libs in the resulting image since the openshift-install binary is dynamically linked when using libvirt because it's built with CGO_ENABLED=1 and there is no static libvirt library shipped in libvirt RPM builds. Eventually, this dynamically linked binary will probably need to be published as a separate image (or perhaps in installer-artifacts) similarly to how the binary for mac is made available.
5 tasks
stbenjam
reviewed
Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a variant of
images/installer/Dockerfile.cithat builds an image withkni-installat/usr/bin/openshift-install - this is sooc adm release extract --toolsknows how to extact it.We also install libvirt-libs in the resulting image since the openshift-install binary is dynamically linked when using libvirt because it's built with
CGO_ENABLED=1and there is no static libvirt library shipped in libvirt RPM builds.Eventually, this dynamically linked binary will probably need to be published as a separate image (or perhaps in installer-artifacts) similarly to how the binary for mac is made available.
See also openshift-metal3/dev-scripts#401