Update install-config #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmc
force-pushed
the
installconfig-networking
branch
from
dbf028b to
db6c447
Compare
Contributor
Author
|
Sorry for all the pushes, should be done now. |
Update to v1beta3 install-config.yaml Use the defaults for everything except the pieces of information that are required or that we want to override. We were setting the machine pool replicas to null to try and get "create cluster" to launch a bootstrap VM but no masters. According to the "FIXME: this doesn't work", it looks like we're not depending on this right now. The connection URI isn't actually used for generating ignition configs.
markmc
force-pushed
the
installconfig-networking
branch
from
7c83451 to
805beac
Compare
Contributor
Author
|
No worries, rebased and squashed |
hardys
reviewed
Feb 21, 2019
| URI: qemu:///system | ||
| network: | ||
| if: tt0 | ||
| libvirt: {} |
There was a problem hiding this comment.
Ah, yeah, good catch - the URI is there because I was originally trying to use the openshift-install libvirt backend to launch the bootstrap vm via "create cluster", but it turns out evern with replicas:null it still builds a single master node as well.
Collaborator
There was a problem hiding this comment.
While we're on this lets change this to platform: none - it should be the same as libvirt, but later on we change it for baremetal use cases
There was a problem hiding this comment.
I tried this and you need to do:
platform:
none: {}
Just setting platform to either null or the string none doesn't work, there's a json marshalling error from openshift-install
hardys
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to v1beta3 version. Remove everything except where we want to supply required information or override the defaults.