Skip to content

Add support for provisioning over IPv6 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stbenjam merged 1 commit into from
Feb 20, 2020
Merged

Add support for provisioning over IPv6 #833

stbenjam merged 1 commit into from
Feb 20, 2020

Conversation

@derekhiggins
Copy link
Collaborator

@derekhiggins derekhiggins commented Oct 24, 2019

Sticking to the same defaults as the metal3-dev-env support
for consistency.

@derekhiggins
Copy link
Collaborator Author

derekhiggins commented Oct 24, 2019

/hold

@derekhiggins derekhiggins changed the title Add support for provisioning over IPv6 [WIP]: Add support for provisioning over IPv6 Oct 24, 2019
@derekhiggins derekhiggins force-pushed the ipv6-dev-scripts branch 2 times, most recently from e7da2cf to 5ed2a34 Compare November 28, 2019 17:30
@derekhiggins
Copy link
Collaborator Author

derekhiggins commented Nov 28, 2019

For IPv6 should be tested with openshift/installer#2727

@derekhiggins derekhiggins changed the title [WIP]: Add support for provisioning over IPv6 Add support for provisioning over IPv6 Dec 20, 2019
@derekhiggins derekhiggins added the CI check this PR with CI label Dec 20, 2019
@derekhiggins derekhiggins mentioned this pull request Dec 20, 2019
Closed
@metal3ci
Copy link

metal3ci commented Dec 20, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1390/

@metal3ci
Copy link

metal3ci commented Jan 14, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1418/

@metal3ci
Copy link

metal3ci commented Jan 16, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1426/

@stbenjam
Copy link
Member

stbenjam commented Feb 7, 2020

The installer IPv6 fixes have landed. This needs a rebase when you get a chance.

I assume we also still need the UEFI/IPv6-compatible (snponly.efi) iPXE in the OpenShift ironic images

@metal3ci
Copy link

metal3ci commented Feb 14, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1502/

@metal3ci
Copy link

metal3ci commented Feb 19, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1511/

@metal3ci
Copy link

metal3ci commented Feb 19, 2020

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1514/

stbenjam
stbenjam reviewed Feb 19, 2020
View reviewed changes
stbenjam
stbenjam reviewed Feb 19, 2020
View reviewed changes
@metal3ci
Copy link

metal3ci commented Feb 20, 2020

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1521/

stbenjam
stbenjam reviewed Feb 20, 2020
View reviewed changes
02_configure_host.sh Outdated
if ! sudo iptables -C INPUT -i baremetal -p udp -m udp --dport 6230:${VBMC_MAX_PORT} -j ACCEPT 2>/dev/null ; then
sudo iptables -I INPUT -i baremetal -p udp -m udp --dport 6230:${VBMC_MAX_PORT} -j ACCEPT
if ! sudo $IPTABLES -C INPUT -i baremetal -p udp -m udp --dport 6230:6235 -j ACCEPT 2>/dev/null ; then
sudo $IPTABLES -I INPUT -i baremetal -p udp -m udp --dport 6230:6235 -j ACCEPT
Copy link
Member

@stbenjam stbenjam Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this: can you put back VBMC_MAX_PORT?

Otherwise this is good to go.

Copy link
Collaborator Author

@derekhiggins derekhiggins Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

stbenjam
stbenjam reviewed Feb 20, 2020
View reviewed changes
ocp_install_env.sh Outdated
clusterOSImage: http://${MIRROR_IP}/images/${MACHINE_OS_IMAGE_NAME}?sha256=${MACHINE_OS_IMAGE_SHA256}
bootstrapOSImage: http://$(wrap_if_ipv6 $MIRROR_IP)/images/${MACHINE_OS_BOOTSTRAP_IMAGE_NAME}?sha256=${MACHINE_OS_BOOTSTRAP_IMAGE_UNCOMPRESSED_SHA256}
clusterOSImage: http://$(wrap_if_ipv6 $MIRROR_IP)/images/${MACHINE_OS_IMAGE_NAME}?sha256=${MACHINE_OS_IMAGE_SHA256}
provisioningNetworkCIDR: $PROVISIONING_NETWORK
Copy link
Member

@stbenjam stbenjam Feb 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed, it's handled by the network_configuration function above, to keep compatability with 4.3

Copy link
Collaborator Author

@derekhiggins derekhiggins Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@derekhiggins
Add support for provisioning over IPv6
327d1c2 
Sticking to the same defaults as the metal3-dev-env support
for consistency.
@stbenjam
Copy link
Member

stbenjam commented Feb 20, 2020

Thanks, LGTM

@stbenjam stbenjam merged commit 7474d1f into openshift-metal3:master Feb 20, 2020
@metal3ci
Copy link

metal3ci commented Feb 20, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1523/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam stbenjam left review comments

Assignees

No one assigned

Labels

CI check this PR with CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekhiggins @metal3ci @stbenjam