Skip to content

Conversation

@derekhiggins
Copy link
Collaborator

No longer build a custom version

@derekhiggins
Copy link
Collaborator Author

Doesn't work, get the following warning during cluster create
level=warning msg=" Discarding the "Bootstrap Ignition Config" that was provided in the target directory because its dependencies are dirty and it needs to be regenerated"

any ideas ?

@hardys
Copy link

hardys commented Oct 3, 2019

Hmm I've seen that before when either assets generated in the earlier installer stages (e.g generated manifests etc) get modified, or if there is a long delay between the generation of the ignition-config so that e.g certs need to be regenerated.

Not sure why either would happen in this case though...

@stbenjam
Copy link
Member

stbenjam commented Oct 3, 2019

Yup, we saw this before, but it was because the generated install-config.yaml wasn't identical to the one we created by the shell script, it was just a missing field that wasn't really relevant to anything. It looks like you're modifying the bootstrap ignition, I'm not sure you can do that when doing IPI installs, maybe ask the installer team on slack if there's a way to make it ignore the discrepancy?

if [ -e ./assets/generated/99_local-registry.yaml ] ; then
cp ${assets_dir}/install-config.yaml{.tmp,}
$OPENSHIFT_INSTALLER --dir "${assets_dir}" --log-level=debug create ignition-configs
yq .spec.config.storage.files[0] ./assets/generated/99_local-registry.yaml | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it specified that yq is a requirement to run dev-scripts?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's installed along with the other dependencies here:

https://github.com/metal3-io/metal3-dev-env/blob/master/vm-setup/roles/packages_installation/defaults/main.yml#L117

It'd be nice to remove that requirement since it's a pip install, there are other approaches we could use such as https://github.com/ashcrow/filetranspiler but for now yq works.

@derekhiggins
Copy link
Collaborator Author

We can probably just close this, the approach being discussed in
#856
is the correct way to do this with ssl registries.

@hardys
Copy link

hardys commented Dec 17, 2019

closing per comment from @derekhiggins

@hardys hardys closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants