WIP: Add new items for configuring the BMO to the baremetal platform. #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration information for the baremetal pod to the baremetal platform config. This can then be picked up in the installer and used to set the platformStatus.
Contributor
Author
|
You'll also need this: openshift/installer#2449 |
hardys
reviewed
Oct 3, 2019
| provisioningNetworkCIDR: "172.22.0.0/24" | ||
| provisioningIP: "172.22.0.3/24" | ||
| provisioningDHCPRange: "172.22.0.10,172.22.0.100" | ||
| rhcosImageURL: "${RHCOS_IMAGE_URL}" |
There was a problem hiding this comment.
As mentioned on the installer PR we shouldn't add rhcosImageURL because it's data that's already known to the installer - we only care about RHCOS_IMAGE_URL in dev-scripts because we cache the image
hardys
reviewed
Oct 3, 2019
| dnsVIP: ${DNS_VIP} | ||
| provisioningInterface: "ens3" | ||
| provisioningNetworkCIDR: "172.22.0.0/24" | ||
| provisioningIP: "172.22.0.3/24" |
There was a problem hiding this comment.
All of these should have defaults in the installer PR, e.g see pkg/types/baremetal/defaults/platform.go
sadasu
reviewed
Oct 10, 2019
| source logging.sh | ||
| source utils.sh | ||
| source common.sh | ||
| source ocp_install_env.sh |
Contributor
There was a problem hiding this comment.
The changes in this file seem to be a no-op.
Contributor
Author
|
This isn't needed any more. The new version has sane defaults so you don't really need to configure it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration information for the baremetal pod to the baremetal
platform config. This can then be picked up in the installer and used
to set the platformStatus.