Skip to content

use consumerRef instead of machineRef when registering hosts#649

Closed
dhellmann wants to merge 1 commit intoopenshift-metal3:masterfrom
dhellmann:machineref-to-consumerref
Closed

use consumerRef instead of machineRef when registering hosts#649
dhellmann wants to merge 1 commit intoopenshift-metal3:masterfrom
dhellmann:machineref-to-consumerref

Conversation

@dhellmann
Copy link
Copy Markdown
Member

No description provided.

@dhellmann
Copy link
Copy Markdown
Member Author

This should not be merged until openshift/cluster-api-provider-baremetal#34 has landed and a new image is available.

@russellb
Copy link
Copy Markdown
Member

russellb commented Jul 2, 2019

@dhellmann dev-scripts still deploys an upstream BMO image though, so I don't think you have to block on the openshift PR?

@hardys hardys added the CI check this PR with CI label Jul 3, 2019
@hardys
Copy link
Copy Markdown

hardys commented Jul 3, 2019

@dhellmann dev-scripts still deploys an upstream BMO image though, so I don't think you have to block on the openshift PR?

Yeah that's right, the 08 script is still deploying the upstream BMO with a sedded namespace so lets see what CI says :)

@metal3ci
Copy link
Copy Markdown

metal3ci commented Jul 3, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/825/

@metal3ci
Copy link
Copy Markdown

metal3ci commented Jul 5, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/833/

@hardys
Copy link
Copy Markdown

hardys commented Jul 5, 2019

@dhellmann I think CI is failing because your fork of dev-scripts doesn't have the same name as the main repo:

+ git clone https://github.com/openshift-metal3/metal3-dev-scripts
Cloning into 'metal3-dev-scripts'...
fatal: could not read Username for 'https://github.com': No such device or address

I'm not sure if there's some way we can teach CI to figure out the fork relationship, perhaps you could just rename your fork in the meantime?

@hardys
Copy link
Copy Markdown

hardys commented Jul 5, 2019

cc @derekhiggins I think this is happening prior to run-ci.sh, can we perhaps look at the PR repo instead of the fork origin?

@dhellmann
Copy link
Copy Markdown
Member Author

I have renamed my repo, for now. How do I re-run the test job?

@dhellmann dhellmann closed this Jul 5, 2019
@dhellmann
Copy link
Copy Markdown
Member Author

Replaced with #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI check this PR with CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants