Add sanity check to vip-prepender #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had a deployment where the DNS VIP was not properly added to resolv.conf. There isn't enough detail in the logs from the script to determine what went wrong, so this change adds some more logging and a sanity check that we actually did the thing we were trying to do.
|
lgtm - I guess we'll want something similar to be added to openshift/machine-config-operator#795 cc @bcrochet |
hardys
approved these changes
Jun 20, 2019
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/776/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a deployment where the DNS VIP was not properly added
to resolv.conf. There isn't enough detail in the logs from the script
to determine what went wrong, so this change adds some more logging
and a sanity check that we actually did the thing we were trying to do.