Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-36506: Fix config for disconnected cluster #1707

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

derekhiggins
Copy link
Collaborator

@derekhiggins derekhiggins commented Oct 9, 2024

Ensure all but BMC traffic goes via the proxy

@openshift-ci openshift-ci bot requested review from bfournie and zaneb October 9, 2024 14:27
@elfosardo
Copy link
Member

/approve

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@derekhiggins
Copy link
Collaborator Author

/hold
still testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@derekhiggins derekhiggins force-pushed the noproxy branch 4 times, most recently from 5164494 to 101dc9e Compare October 16, 2024 09:39
Ensure all but BMC traffic goes via the proxy
@derekhiggins derekhiggins changed the title OCPBUGS-36506: Conditionaly add image mirror to no_proxy OCPBUGS-36506: Fix config for disconnected cluster Oct 16, 2024
Copy link

openshift-ci bot commented Oct 16, 2024

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 2f1f260 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia 2f1f260 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 2f1f260 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 2f1f260 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@derekhiggins
Copy link
Collaborator Author

/retest-required

@derekhiggins
Copy link
Collaborator Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2024
@iurygregory
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 46dccb7 into openshift-metal3:master Oct 18, 2024
9 of 13 checks passed
@sgoveas
Copy link
Contributor

sgoveas commented Oct 21, 2024

/jira refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants