Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: configure install-config.yaml proxy when required #1697

Conversation

andfasano
Copy link
Member

This patch fixes the agent scenarios when a proxy is configured via the INSTALLER_PROXY config var.
Without this patch, all the (connected) scenario - such as the following - are broken:

export AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4
export INSTALLER_PROXY=true

@openshift-ci openshift-ci bot requested review from bfournie and lranjbar August 27, 2024 13:01
@andfasano
Copy link
Member Author

/test ?

Copy link

openshift-ci bot commented Aug 27, 2024

@andfasano: The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test e2e-metal-ipi-bm
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial-ipv4
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test e2e-metal-ipi-bm-bond
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-v6
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-upgrade
  • /test e2e-metal-ipi-upgrade-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-ha-dualstack
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andfasano
Copy link
Member Author

Note: useful to test openshift/oc#1857

Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@bfournie
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@andfasano
Copy link
Member Author

/test images

@openshift-merge-bot openshift-merge-bot bot merged commit 24aed67 into openshift-metal3:master Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants