Skip to content

AGENT-242: Enable agent installer installs for arm64 #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 12, 2023
Merged

AGENT-242: Enable agent installer installs for arm64 #1518

openshift-merge-robot merged 1 commit into from
Jul 12, 2023

Conversation

@jeffdyoung
Copy link
Contributor

@jeffdyoung jeffdyoung commented Mar 7, 2023

Enable the ability to test arm64 with agent installer: openshift/installer#6401

@openshift-ci openshift-ci bot requested review from celebdor and zaneb March 7, 2023 20:16
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

Hi @jeffdyoung. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor

bfournie commented Mar 7, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2023
andfasano
andfasano reviewed Mar 9, 2023
View reviewed changes
@celebdor
Copy link
Collaborator

celebdor commented Mar 10, 2023

/retitle AGENT-242: Enable agent installer installs for arm64

@openshift-ci openshift-ci bot changed the title Enable agent installer installs for arm64 AGENT-242: Enable agent installer installs for arm64 Mar 10, 2023
@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Mar 13, 2023

/retest

@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Mar 14, 2023

/retest

@jeffdyoung jeffdyoung requested review from andfasano and removed request for celebdor and zaneb March 14, 2023 12:44
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Mar 31, 2023

/retest

@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented May 25, 2023

on CentOS Stream 9 with kernel Linux 5.14.0-316.el9.aarch64, we get "libvirtError: unsupported configuration: Emulator '/usr/libexec/qemu-kvm' does not support virt type 'kvm'"

@jeffdyoung jeffdyoung force-pushed the arm_agent branch 2 times, most recently from acb9af4 to 3320e39 Compare June 1, 2023 19:27
@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jun 1, 2023 •
edited
Loading

@pawanpinjarkar I took a look at this, found a few issues:
In metal3-dev-env :

  • Need to change machine='virt-rhel8.2.0' to machine='virt' here

  • Creating qcow2 images with virsh vol-create-as requires additional steps in Centos9? I had to run this command on the qcow2 files to start the vms:
    qemu-img amend -o compat=v3 <filename.qcow2> Maybe related to this

(I've stashed a few hacks around these here)

In dev-scripts:

  • Seeing network fails related to starting/stopping ostestbm:
+(./02_configure_host.sh:236): sudo virsh net-destroy ostestbm
Network ostestbm destroyed

+(./02_configure_host.sh:237): sudo virsh net-start ostestbm
error: Failed to start network ostestbm
error: error creating bridge interface ostestbm: File exists

worked around by replacing this with:

    sudo ifdown ${BAREMETAL_NETWORK_NAME} || true
    sudo virsh net-start ${BAREMETAL_NETWORK_NAME}

@zaneb @andfasano @celebdor IMO this PR should merge as-is. I'm happy to create a new ARMOCP ticket to support arm w/centos9+rhel9 (if needed). ATM, I don't have an x86 machine to test, do you all know if there are similar issues there?

@zaneb
Copy link
Member

zaneb commented Jul 6, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
andfasano
andfasano reviewed Jul 6, 2023
View reviewed changes
jeffdyoung
jeffdyoung commented Jul 6, 2023
View reviewed changes
@andfasano
Copy link
Member

andfasano commented Jul 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jul 6, 2023

/retest

5 similar comments
@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jul 7, 2023

/retest

@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jul 10, 2023

/retest

@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jul 11, 2023

/retest

@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jul 11, 2023

/retest

@jeffdyoung
Copy link
Contributor Author

jeffdyoung commented Jul 12, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit d06b36e into openshift-metal3:master Jul 12, 2023
@jeffdyoung jeffdyoung deleted the arm_agent branch July 12, 2023 11:57
@rwsu rwsu mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jeffdyoung @bfournie @celebdor @pawanpinjarkar @zaneb @andfasano @openshift-merge-robot