Skip to content

Conversation

@bfournie
Copy link
Contributor

@bfournie bfournie commented Jul 8, 2022

This simulates a disconnect from the masters when using the agent with mirroring. It sets a bogus /etc/hosts entry so that the local mirror must be used. This is currently needed since we must have a valid connection to create the mirror and create the iso so we can't break the connection until after that's done.

Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Can you also mention the Jira number in the commit message and PR title?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
done

# Set a bogus entry in /etc/hosts to break remote access
ssh "${ssh_opts[@]}" "echo '125.12.15.15 quay.io' | sudo tee -a /etc/hosts "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mirroring command I see from dev-scripts is:
oc adm release mirror --insecure=true -a /opt/dev-scripts/pull_secret.json --from registry.ci.openshift.org/ocp/release:4.11.0-0.nightly-2022-07-13-131410 --to-release-image virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:4.11.0-0.nightly-2022-07-13-131410 --to virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
Shouldn't there be an entry for registry.ci.openshift.org?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there should be an entry for registry also, added it.

@bfournie bfournie changed the title For agent mirror testing force disconnect from masters AGENT-287: For agent mirror testing force disconnect from masters Jul 14, 2022
This simulates a disconnect from the masters when using the
agent with mirroring. It sets a bogus /etc/hosts entry so that the local
mirror mut be used.  This is currently needed since we must have a valid
connection to create the mirror and create the iso so we can't break the
connection until after that's done.
@bfournie bfournie force-pushed the agent-force-mirror-disconnect branch from d3b22ec to 7589a92 Compare July 14, 2022 12:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@bfournie
Copy link
Contributor Author

/lgtm

Can you also mention the Jira number in the commit message and PR title?

Added

Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@celebdor
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2022
@openshift-ci openshift-ci bot merged commit 1490fe3 into openshift-metal3:master Jul 16, 2022
@bfournie bfournie deleted the agent-force-mirror-disconnect branch January 18, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants