-
Notifications
You must be signed in to change notification settings - Fork 202
AGENT-287: For agent mirror testing force disconnect from masters #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-287: For agent mirror testing force disconnect from masters #1424
Conversation
pawanpinjarkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can you also mention the Jira number in the commit message and PR title?
| done | ||
|
|
||
| # Set a bogus entry in /etc/hosts to break remote access | ||
| ssh "${ssh_opts[@]}" "echo '125.12.15.15 quay.io' | sudo tee -a /etc/hosts " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mirroring command I see from dev-scripts is:
oc adm release mirror --insecure=true -a /opt/dev-scripts/pull_secret.json --from registry.ci.openshift.org/ocp/release:4.11.0-0.nightly-2022-07-13-131410 --to-release-image virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:4.11.0-0.nightly-2022-07-13-131410 --to virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
Shouldn't there be an entry for registry.ci.openshift.org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there should be an entry for registry also, added it.
This simulates a disconnect from the masters when using the agent with mirroring. It sets a bogus /etc/hosts entry so that the local mirror mut be used. This is currently needed since we must have a valid connection to create the mirror and create the iso so we can't break the connection until after that's done.
d3b22ec to
7589a92
Compare
Added |
rwsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This simulates a disconnect from the masters when using the agent with mirroring. It sets a bogus /etc/hosts entry so that the local mirror must be used. This is currently needed since we must have a valid connection to create the mirror and create the iso so we can't break the connection until after that's done.