Skip to content

Add ENABLE_BOOTSTRAP_STATIC_IP option #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Jul 19, 2022
Merged

Add ENABLE_BOOTSTRAP_STATIC_IP option #1336

openshift-ci merged 1 commit into from
Jul 19, 2022

Conversation

@hardys
Copy link

@hardys hardys commented Jan 12, 2022 •
edited
Loading

This configures a static IP for the bootstrap external NIC

Requires openshift/installer#5787

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2022
@openshift-ci openshift-ci bot requested review from cybertron and flaper87 January 12, 2022 16:49
@hardys
Copy link
Author

hardys commented Jan 12, 2022

/cc @derekhiggins - as discussed this relates to #1297

@hardys hardys force-pushed the bootstrap_static_ip branch 2 times, most recently from 114ea93 to 9d22b28 Compare January 12, 2022 22:16
@hardys
Copy link
Author

hardys commented Jan 12, 2022

Ok this is working for me now with ipv4, still needs ipv6 support before removing the WIP

hardys
hardys commented Jan 12, 2022
View reviewed changes
@hardys hardys force-pushed the bootstrap_static_ip branch 3 times, most recently from dbe3560 to ab79927 Compare January 13, 2022 10:47
@hardys hardys changed the title [WIP] Add BOOTSTRAP_STATIC_IP option Add BOOTSTRAP_STATIC_IP option Jan 13, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2022
@hardys hardys force-pushed the bootstrap_static_ip branch from ab79927 to 318bcac Compare January 13, 2022 10:48
@hardys hardys mentioned this pull request Jan 13, 2022
Closed
derekhiggins
derekhiggins reviewed Jan 13, 2022
View reviewed changes
@hardys hardys force-pushed the bootstrap_static_ip branch from 318bcac to 23d29ac Compare January 14, 2022 10:27
@derekhiggins
Copy link
Collaborator

derekhiggins commented Jan 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
andfasano
andfasano approved these changes Jan 14, 2022
View reviewed changes
@hardys hardys force-pushed the bootstrap_static_ip branch from 23d29ac to b0d389f Compare January 14, 2022 15:31
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@hardys hardys force-pushed the bootstrap_static_ip branch from b0d389f to 46bda3b Compare January 14, 2022 15:32
@hardys hardys changed the title Add BOOTSTRAP_STATIC_IP option Add ENABLE_BOOTSTRAP_STATIC_IP option Jan 14, 2022
@derekhiggins
Copy link
Collaborator

derekhiggins commented Jan 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@derekhiggins
Copy link
Collaborator

derekhiggins commented Jan 18, 2022

/test e2e-metal-ipi

@andfasano
Copy link
Member

andfasano commented Jan 18, 2022

/test e2e-metal-ipi-serial-ipv4
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

1 similar comment
@andfasano
Copy link
Member

andfasano commented Jan 19, 2022

/test e2e-metal-ipi-serial-ipv4
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

@hardys
Copy link
Author

hardys commented Jan 31, 2022

/test e2e-metal-ipi-serial-ovn-ipv6

1 similar comment
@hardys
Copy link
Author

hardys commented Feb 2, 2022

/test e2e-metal-ipi-serial-ovn-ipv6

@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2022

/retest

reihl
reihl reviewed Feb 3, 2022
View reviewed changes
reihl
reihl reviewed Feb 3, 2022
View reviewed changes
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2022
@hardys hardys force-pushed the bootstrap_static_ip branch from 46bda3b to 87412ba Compare May 12, 2022 14:33
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 12, 2022
@hardys
Copy link
Author

hardys commented May 12, 2022

/cc @honza

Updated to align with openshift/installer#5787

@openshift-ci openshift-ci bot requested a review from honza May 12, 2022 14:34
@hardys hardys mentioned this pull request May 12, 2022
Merged
@openshift-ci
Copy link

openshift-ci bot commented May 29, 2022

@hardys: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2022
@pamoedom
Copy link

pamoedom commented Jul 13, 2022

Hi @hardys, could be possible to obtain some status of this PR? do we have any blockade?

FYI, we need it in order to cover METAL-175 because we don't have a fully static IPI BM env where to test it, we are using dev-scripts approach to achieve that, thanks.

Best Regards.

Add ENABLE_BOOTSTRAP_STATIC_IP option
7c1b5d7 
This configures static IP for the bootstrap external NIC

Requires openshift/installer#5787
@hardys hardys force-pushed the bootstrap_static_ip branch from 87412ba to 7c1b5d7 Compare July 18, 2022 10:30
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2022
@hardys
Copy link
Author

hardys commented Jul 18, 2022

/test e2e-metal-ipi

@elfosardo
Copy link
Member

elfosardo commented Jul 19, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@dtantsur
Copy link
Member

dtantsur commented Jul 19, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@hardys
Copy link
Author

hardys commented Jul 19, 2022

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2022

@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi-proxy-ipv4, ci/prow/e2e-metal-ipi-proxy-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2022 •
edited
Loading

@hardys: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 7c1b5d7 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-proxy-ipv6 7c1b5d7 link false /test e2e-metal-ipi-proxy-ipv6
ci/prow/e2e-metal-ipi-proxy-ipv4 7c1b5d7 link false /test e2e-metal-ipi-proxy-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hardys
Copy link
Author

hardys commented Jul 19, 2022

/retest-required

@openshift-ci openshift-ci bot merged commit 8273fa6 into openshift-metal3:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekhiggins derekhiggins derekhiggins left review comments

@cybertron cybertron Awaiting requested review from cybertron

@flaper87 flaper87 Awaiting requested review from flaper87

@honza honza Awaiting requested review from honza

+2 more reviewers

@reihl reihl reihl left review comments

@andfasano andfasano andfasano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@derekhiggins derekhiggins

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@hardys @derekhiggins @andfasano @elfosardo @sadasu @pamoedom @dtantsur @reihl @openshift-merge-robot