Conditionally copy rhcos.json #1317
Conversation
This is only needed in rhcos.sh for old versions which lack the openshift-install coreos-print-stream-json option, and the file moved in openshift/installer#5252 so we should only copy if the "old" location is detected
|
/lgtm |
| # That landed in 4.8, and in 4.10 this file moved, so just | ||
| # skip copying it if it's not in the "old" location ref | ||
| # https://github.com/openshift/installer/pull/5252 | ||
| if [ -f "$OPENSHIFT_INSTALL_PATH/data/data/rhcos.json" ]; then |
There was a problem hiding this comment.
nit: "$OPENSHIFT_INSTALL_PATH/data/data/rhcos.json" should probably be yet another variable
There was a problem hiding this comment.
It wasn't a variable before, and the path is decided by the installer repo - I don't understand under what circumstances someone would want to override this path, can you elaborate?
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-metal-ipi Looks like an issue with the image registry |
|
/refresh |
6 participants
This is only needed in rhcos.sh for old versions which lack the
openshift-install coreos-print-stream-json option, and the
file moved in openshift/installer#5252
so we should only copy if the "old" location is detected