Skip to content

Comments

Allow local gateway mode to be configured with OVN#1238

Merged
openshift-merge-robot merged 1 commit intoopenshift-metal3:masterfrom
jluhrsen:ovn-local-gw
May 13, 2021
Merged

Allow local gateway mode to be configured with OVN#1238
openshift-merge-robot merged 1 commit intoopenshift-metal3:masterfrom
jluhrsen:ovn-local-gw

Conversation

@jluhrsen
Copy link
Contributor

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

@openshift-ci openshift-ci bot requested review from andfasano and cybertron May 11, 2021 22:11
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2021

Hi @jluhrsen. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2021
@jluhrsen
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2021
@stbenjam
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2021
@jluhrsen
Copy link
Contributor Author

/retest

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
@jluhrsen
Copy link
Contributor Author

@stbenjam , could you please review this? The PR as is has no effect on how the presubmit jobs are deployed. they will
take the default shared gateway mode. here is a ovnkube-master log and worker ovnkube-node log showing "shared" being
used. I also updated this PR (since removed) to put `export OVN_LOCAL_GATEWAY_MODE=local" in common.sh to
simulate that variable being available at install and you can see "local" being used in this ovnkube-master log and worker log
from this PRs presubmits.

@jluhrsen
Copy link
Contributor Author

here's the matching PR in release/ that would create a job to take advantage of this one.

@stbenjam
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@stbenjam
Copy link
Member

Thanks!!

@openshift-merge-robot openshift-merge-robot merged commit d5d2d82 into openshift-metal3:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants