Cleanup /var/lib/libvirt/openshift-images

[hardys]

For some reason the virsh --remove-all-storage isn't actually removing
the storage, this may be because we moved to a non-default pool?

This can quickly use up space as each leaked directory is about 2.2G
so lets clean it up until we can find a more robust way to handle
this in the installer.

[cybertron]

Interestingly, I no longer see this happening in my environments. On the node I already cleaned up, I have (with a cluster actively running):

$ ls -lah /var/lib/libvirt/openshift-images/
total 8.0K
drwxr-xr-x. 2 root root 4.0K Nov 18 17:50 .
drwxr-xr-x. 10 root root 4.0K Nov 18 15:03 ..
$

On another node that I didn't clean up I just have a bunch of empty directories there. I wonder if there was a bug that affected deployments during a certain window of time that left a bunch of cruft, but has since been fixed.

[hardys]

Interestingly, I no longer see this happening in my environments. On the node I already cleaned up, I have (with a cluster actively running):

I think it's a corner case where if the installer fails during the terraform apply phase, it then doesn't clean up properly in the destroy cluster step - if your deployment succeeded then I'd expect the existing cleanup to work, but if you somehow cause the deployment of masters to fail I suspect it won't?

[cybertron]

/lgtm

Fair enough. It shouldn't hurt anything to clean these up in any case.

[andfasano]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andfasano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment