Skip to content

Conversation

@hardys
Copy link

@hardys hardys commented Oct 2, 2020

Otherwise MIRROR_IMAGES isn't defined when testing, and we see
a failure to pull the image in the CI logs when test ipv6

Otherwise MIRROR_IMAGES isn't defined when testing, and we see
a failure to pull the image in the CI logs when test ipv6
@hardys
Copy link
Author

hardys commented Oct 2, 2020

@stbenjam @trozet @danwinship

This fixes one problem with must-gather for the e2e-ipi-baremetal ipv6 CI, but it's still possible for the gather to get stuck if the serviceNetwork is completely broken, e.g:

[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout
[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout
[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout
[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout
[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout
[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout
[must-gather-rgdnc] POD Unable to connect to the server: dial tcp [fd02::1]:443: i/o timeout

Any suggestions on how we might handle that - should we fall back to scp and just copy the pod logs off each node perhaps?

@danwinship
Copy link
Contributor

In general, must-gather depends on a minimal level of cluster functionality...

I'd say, if it turns out that "must-gather failed because the service network isn't up" turns out to be a recurring problem, then we should try to work around it, but it's OK to not worry about for now

@dcbw
Copy link

dcbw commented Oct 3, 2020

/lgtm

@openshift-ci-robot
Copy link

@dcbw: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@derekhiggins
Copy link
Collaborator

/approved

@andfasano
Copy link
Member

/lgtm

@stbenjam
Copy link
Member

stbenjam commented Oct 5, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit c796867 into openshift-metal3:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants