-
Notifications
You must be signed in to change notification settings - Fork 202
Add network.sh to must_gather.sh #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network.sh to must_gather.sh #1125
Conversation
Otherwise MIRROR_IMAGES isn't defined when testing, and we see a failure to pull the image in the CI logs when test ipv6
|
This fixes one problem with must-gather for the e2e-ipi-baremetal ipv6 CI, but it's still possible for the gather to get stuck if the serviceNetwork is completely broken, e.g: Any suggestions on how we might handle that - should we fall back to scp and just copy the pod logs off each node perhaps? |
|
In general, must-gather depends on a minimal level of cluster functionality... I'd say, if it turns out that "must-gather failed because the service network isn't up" turns out to be a recurring problem, then we should try to work around it, but it's OK to not worry about for now |
|
/lgtm |
|
@dcbw: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approved |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Otherwise MIRROR_IMAGES isn't defined when testing, and we see
a failure to pull the image in the CI logs when test ipv6