Fetch Pull Request to build local image #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
64bb74f to
d816977
Compare
Member
Author
|
/assign @andfasano @hardys |
elfosardo
force-pushed
the
local-image-pr-fetch
branch
2 times, most recently
from
55fb964 to
dcc9f52
Compare
Member
Author
|
/retest |
cybertron
reviewed
Aug 26, 2020
Contributor
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
Tried this locally. It was a little confusing that _LOCAL_IMAGE also needs to be set even though we don't use the value of the variable since the name of the repo is pulled from the env var name. Might be nice if this could be done standalone.
That said, it seems work as intended, so pending the question inline I'm good with it.
Member
|
/test e2e-metal-ipi |
Member
|
/retest |
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
dcc9f52 to
49098b4
Compare
Member
Author
|
/retest |
4 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
|
/retest |
|
/retest |
Member
|
/test e2e-metal-ipi |
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
49098b4 to
af944d6
Compare
Member
Author
|
/retest |
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
af944d6 to
fb6192c
Compare
|
@elfosardo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
fb6192c to
ac16ec4
Compare
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
ac16ec4 to
01f93fc
Compare
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
01f93fc to
5d9aebd
Compare
Member
|
@elfosardo needs rebase? |
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
5d9aebd to
e6dc147
Compare
elfosardo
force-pushed
the
local-image-pr-fetch
branch
from
e6dc147 to
e77300f
Compare
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Avielyo10
pushed a commit
to Avielyo10/dev-scripts
that referenced
this pull request
Dec 2, 2020
* Simplify additional_trust_bundle() * Pass ca via path instead of via env vars Improve readability Fix loca-bmo script (openshift-metal3#1144) (openshift-metal3#1084) Co-authored-by: Andrea Fasano <60063538+andfasano@users.noreply.github.com> Fix incorrect group name (openshift-metal3#1155) `whoami` does not always match the group name for the user. Use `id -gn` to set the group name properly. Also create GROUP environment variable and replace USER where appropriate for chown commands. Signed-off-by: Melvin Hillsman <mrhillsman@redhat.com> Additional trust bundle (openshift-metal3#1152) * Adding the option to add certs to install-config.yaml * Add ADDITIONAL_TRUST_BUNDLE to the config_example.sh * Avoid additionalTrustBundle duplication & move from sed to awk When MIRROR_IMAGES is set or when using ipv6 (this is always true for ipv6) additionalTrustBundle section gets created, so give precedence to MIRROR_IMAGES CA * In case MIRROR_IMAGES is set, concat ADDITIONAL_TRUST_BUNDLE Co-authored-by: Aviel Yosef <ayosef@redhat.com> Account for podman version < 2.0.0 (openshift-metal3#1151) The default for CentOS 8 is 1.6.4 which does not support units in `podman wait -i`. Add a version check to support both. Follow-up to commit 42af610. Update version detection and make dnsVIP conditional (openshift-metal3#1146) * Store local copy of release info We retrive this several times, so caching locally will be faster, and also provides a useful reference for debugging * Replace OPENSHIFT_VERSION reference with function This variable isn't always set, in particular in CI, so instead of relying on it, we can use a new openshift_version function which derives the version from the locally cached release info. * Only specify dnsVIP for < 4.5 This was removed in openshift/installer#3304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to specify a Pull Request number associated to
an image and build it locally with that change.