Optional provisioning network #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
hardys
reviewed
Jul 21, 2020
stbenjam
force-pushed
the
optional-provisioning
branch
2 times, most recently
from
aaff92a to
c896229
Compare
Member
Author
|
/test e2e-metal-ipi |
stbenjam
force-pushed
the
optional-provisioning
branch
from
3c62881 to
4401393
Compare
Member
Author
|
/retest |
stbenjam
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/test e2e-metal-ipi |
1 similar comment
Member
Author
|
/test e2e-metal-ipi |
stbenjam
force-pushed
the
optional-provisioning
branch
5 times, most recently
from
b0f27a6 to
8d1186e
Compare
This enables support in dev-scripts for optional provisioning network. To use, set PROVISIONING_NETWORK_PROFILE to "Disabled".
stbenjam
force-pushed
the
optional-provisioning
branch
from
8d1186e to
787ca63
Compare
Member
Author
|
/test e2e-metal-ipi |
1 similar comment
Member
Author
|
/test e2e-metal-ipi |
Member
Author
|
@hardys Please take another look, this should be ready to go |
|
/approve |
openshift-ci-robot
added
the
approved
celebdor
requested changes
Aug 18, 2020
Co-authored-by: Antoni Segura Puimedon <[email protected]>
Member
Author
|
@celebdor Could you take another look please? |
Collaborator
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
celebdor
approved these changes
Aug 19, 2020
Member
Author
|
/test e2e-metal-ipi Failure due to on-going known issue with building release images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support in dev-scripts for optional provisioning network.
To use, set PROVISIONING_NETWORK_PROFILE to "Disabled".