WIP: Remove OLM operator on startup#857
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Pull Request Test Coverage Report for Build 2347
💛 - Coveralls |
| } else { | ||
| klog.Infof("Removing performance-addon-operator subscription %s", subscription.Name) | ||
| if subscription.Status.CurrentCSV != paoCSV { | ||
| klog.Warningf("Subscription to be removed contains a current CSV version %s which is different from %s", subscription.Status.CurrentCSV, paoCSV) |
There was a problem hiding this comment.
probably we should exit here
There was a problem hiding this comment.
I wonder what can bring us to this scenario at all. maybe this is an overkill
There was a problem hiding this comment.
only if a user will not update a subscription from 4.9 or earlier version(but it should be the unsupported scenario, so I think we should exit with the error that first, you should upgrade to 4.10) and will upgrade to 4.11.
|
|
||
| // uninstall PAO OLM operator and all of its artifacts | ||
| // this should apply only from version 4.11 | ||
| func (r *PerformanceProfileReconciler) removeOLMOperator() error { |
There was a problem hiding this comment.
you will need a bunch of new permissions for OLM related resources
yanirq
force-pushed
the
remove_olm
branch
5 times, most recently
from
f0b3369 to
3297282
Compare
Signed-off-by: Yanir Quinn <yquinn@redhat.com>
|
@yanirq: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is implemented under the new repository for PAO: |
3 participants
Once PAO is merged and shipped with NTO (as one controller) there is a need to clean up the old OLM operator, especially in upgrade use cases.
This PR should be aligned with openshift/cluster-node-tuning-operator#314 .
Functional tests and the existing deployment schemes in this repo will align either in this or in an additional PR/s