Skip to content

Remove RT kernel workaround and use new MC config instead#47

Merged
openshift-merge-robot merged 3 commits intoopenshift-kni:masterfrom
slintes:rt-kernel-mco
Jan 24, 2020
Merged

Remove RT kernel workaround and use new MC config instead#47
openshift-merge-robot merged 3 commits intoopenshift-kni:masterfrom
slintes:rt-kernel-mco

Conversation

@slintes
Copy link
Member

@slintes slintes commented Jan 23, 2020

With openshift/machine-config-operator#1330 being merged, we can remove our workaround for installing the RT kernel and use the new config option of MachineConfig.

Not sure when this will be available in CI, so it might fail yet.

Edit: accidentally pushed a change on go vet, let's see what CI thinks about it. The original version did not work for me with Go 1.13.5

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 23, 2020
@slintes slintes requested a review from davidvossel January 23, 2020 16:00
Copy link
Member

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I like it when we remove code :)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@slintes
Copy link
Member Author

slintes commented Jan 23, 2020

/hold

e2e test isn't required but should be green for this

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2020
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

looks good, this should be primed for merging once an ocp build picks up the change and our ci passes

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@slintes
Copy link
Member Author

slintes commented Jan 24, 2020

cluster bootstrap failed

/retest

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@slintes
Copy link
Member Author

slintes commented Jan 24, 2020

The RT kernel test passed! I only forgot to remove another test which checks existence of the removed rt kernel script.

@slintes
Copy link
Member Author

slintes commented Jan 24, 2020

/retest

@davidvossel
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, MarSik, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes
Copy link
Member Author

slintes commented Jan 24, 2020

And we are green :)
@davidvossel do you mind putting a new lgmt on it? Thanks!

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 96a8787 into openshift-kni:master Jan 24, 2020
@slintes
Copy link
Member Author

slintes commented Jan 24, 2020

And we are green :)
@davidvossel do you mind putting a new lgmt on it? Thanks!

/hold cancel

LOL, you were a bit faster than me :)

dshchedr pushed a commit to dshchedr/performance-addon-operators that referenced this pull request Mar 26, 2020
Install gcc (hoping it's the last dependency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants