Remove RT kernel workaround and use new MC config instead#47
Remove RT kernel workaround and use new MC config instead#47openshift-merge-robot merged 3 commits intoopenshift-kni:masterfrom slintes:rt-kernel-mco
Conversation
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
MarSik
left a comment
There was a problem hiding this comment.
/lgtm
I like it when we remove code :)
|
/hold e2e test isn't required but should be green for this |
davidvossel
left a comment
There was a problem hiding this comment.
/lgtm
looks good, this should be primed for merging once an ocp build picks up the change and our ci passes
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
|
cluster bootstrap failed /retest |
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
|
The RT kernel test passed! I only forgot to remove another test which checks existence of the removed rt kernel script. |
|
/retest |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, MarSik, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
And we are green :) /hold cancel |
LOL, you were a bit faster than me :) |
Install gcc (hoping it's the last dependency)
With openshift/machine-config-operator#1330 being merged, we can remove our workaround for installing the RT kernel and use the new config option of MachineConfig.
Not sure when this will be available in CI, so it might fail yet.
Edit: accidentally pushed a change on
go vet, let's see what CI thinks about it. The original version did not work for me with Go 1.13.5