e2e: skip HyperShift install test until OCPBUGS-88738 - #4580
openshift-merge-bot[bot] merged 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds HyperShift-specific skipping in the durability test flow and updates HyperShift teardown to delete the mirrored KubeletConfig ConfigMap from the hosted cluster namespace. ChangesHyperShift durability flow
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tal-or
left a comment
There was a problem hiding this comment.
I'm not sure the fix is correct, because we'll end with stale RTE configMaps on the production as well.
Fixing that as part of the tests is not enough.
The main concern here is that the operator will refer to the stale RTE configMaps
dfd7363 to
5931bc2
Compare
Signed-off-by: Sargun Narula <snarula@redhat.com>
5931bc2 to
2732e07
Compare
|
|
||
| // skipHyperShiftKCDetachReason documents why HyperShift durability specs are skipped. | ||
| // Remove once hypershift#8890 (OCPBUGS-88738) is in CI payloads and teardown passes. | ||
| skipHyperShiftKCDetachReason = "Skipped until OCPBUGS-88738 (hypershift#8890): HCCO does not delete mirrored kubelet ConfigMap on guest cluster after KC detach" |
There was a problem hiding this comment.
in this case the constant is unnecessary, but no big deal
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, SargunNarula, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
After openshift/hypershift#8672 (OCPBUGS-86949), HCCO no longer deletes mirrored kubelet ConfigMaps when they are detached from a NodePool. As a result, the operator retains the derived RTE ConfigMap, causing the install test cleanup assertion to fail.
This PR therefore skips all
[Install] durabilityspecs on HyperShift until the platform fix lands in hypershift#8890 (OCPBUGS-88738).