Skip to content

e2e: skip HyperShift install test until OCPBUGS-88738 - #4580

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-kni:mainfrom
SargunNarula:fix-hypershift-e2e-kc-teardown
Jul 8, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-kni:mainfrom
SargunNarula:fix-hypershift-e2e-kc-teardown

Conversation

@SargunNarula

@SargunNarula SargunNarula commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

After openshift/hypershift#8672 (OCPBUGS-86949), HCCO no longer deletes mirrored kubelet ConfigMaps when they are detached from a NodePool. As a result, the operator retains the derived RTE ConfigMap, causing the install test cleanup assertion to fail.

This PR therefore skips all [Install] durability specs on HyperShift until the platform fix lands in hypershift#8890 (OCPBUGS-88738).

@openshift-ci
openshift-ci Bot requested review from mrniranjan and shajmakh July 2, 2026 18:32
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@SargunNarula, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5f901856-dcb4-46e7-8648-cb1d058cc5a3

📥 Commits

Reviewing files that changed from the base of the PR and between dfd7363 and 2732e07.

📒 Files selected for processing (1)
  • test/e2e/install/install_test.go
📝 Walkthrough

Walkthrough

Adds HyperShift-specific skipping in the durability test flow and updates HyperShift teardown to delete the mirrored KubeletConfig ConfigMap from the hosted cluster namespace.

Changes

HyperShift durability flow

Layer / File(s) Summary
Skip durability on HyperShift
test/e2e/install/install_test.go
Adds a skip reason, checks for platform.HyperShift, and avoids teardown when the spec was skipped.
Delete mirrored ConfigMap in teardown
test/internal/deploy/hypershift.go
Adds the hosted-cluster KubeletConfig namespace constant and deletes the mirrored ConfigMap during teardown with client.IgnoreNotFound.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the HyperShift install-test skip introduced by the PR.
Description check ✅ Passed The description is directly related to the HyperShift test teardown issue and skip workaround in this change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Tal-or Tal-or left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the fix is correct, because we'll end with stale RTE configMaps on the production as well.
Fixing that as part of the tests is not enough.
The main concern here is that the operator will refer to the stale RTE configMaps

@SargunNarula
SargunNarula force-pushed the fix-hypershift-e2e-kc-teardown branch 2 times, most recently from dfd7363 to 5931bc2 Compare July 7, 2026 12:15
@SargunNarula SargunNarula changed the title e2e: fix HyperShift install test teardown after OCPBUGS-86949 e2e: skip HyperShift install test until OCPBUGS-88738 Jul 7, 2026
Signed-off-by: Sargun Narula <snarula@redhat.com>
@SargunNarula
SargunNarula force-pushed the fix-hypershift-e2e-kc-teardown branch from 5931bc2 to 2732e07 Compare July 7, 2026 12:23

@ffromani ffromani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Comment on lines +70 to +73

// skipHyperShiftKCDetachReason documents why HyperShift durability specs are skipped.
// Remove once hypershift#8890 (OCPBUGS-88738) is in CI payloads and teardown passes.
skipHyperShiftKCDetachReason = "Skipped until OCPBUGS-88738 (hypershift#8890): HCCO does not delete mirrored kubelet ConfigMap on guest cluster after KC detach"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case the constant is unnecessary, but no big deal

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2026
@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, SargunNarula, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

4 similar comments
@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

@SargunNarula

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot
openshift-merge-bot Bot merged commit eb59c28 into openshift-kni:main Jul 8, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants