-
Notifications
You must be signed in to change notification settings - Fork 148
Added kustomization for performance #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 4 commits into
openshift-kni:master
from
slintes:performance
Jan 14, 2020
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7e013c9
Added kustomization for performance
slintes 335f4cc
Moved namespace to operator, removed ${OPENSHIFT_BUILD_NAMESPACE} han…
slintes c02b052
Merged performace-operator and -profile, retry instead wait
slintes e2b912d
Separated worker-rt labeling and deployment, improved README
slintes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| # TODO handle namespace with var | ||
|
|
||
| resources: | ||
| - operator-namespace.yaml | ||
| - operator_operatorgroup.yaml | ||
| - operator_catalogsource.yaml | ||
| - operator_subscription.yaml | ||
| - performance_profile.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| labels: | ||
| openshift.io/cluster-monitoring: "true" | ||
| name: openshift-performance-addon | ||
| spec: {} |
13 changes: 13 additions & 0 deletions
13
feature-configs/base/performance/operator_catalogsource.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| apiVersion: operators.coreos.com/v1alpha1 | ||
| kind: CatalogSource | ||
| metadata: | ||
| name: performance-addon-operators-catalogsource | ||
| namespace: openshift-marketplace | ||
| spec: | ||
| displayName: Openshift Performance Addon Operators | ||
| icon: | ||
| base64data: "" | ||
| mediatype: "" | ||
| image: quay.io/openshift/performance-addon-operators-registry | ||
| publisher: Red Hat | ||
| sourceType: grpc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| apiVersion: operators.coreos.com/v1 | ||
| kind: OperatorGroup | ||
| metadata: | ||
| name: openshift-performance-addon-operatorgroup | ||
| namespace: openshift-performance-addon | ||
| spec: | ||
| targetNamespaces: | ||
| - openshift-performance-addon |
10 changes: 10 additions & 0 deletions
10
feature-configs/base/performance/operator_subscription.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| apiVersion: operators.coreos.com/v1alpha1 | ||
| kind: Subscription | ||
| metadata: | ||
| name: performance-addon-operators-subscription | ||
| namespace: openshift-performance-addon | ||
| spec: | ||
| channel: alpha | ||
| name: performance-addon-operators | ||
| source: performance-addon-operators-catalogsource | ||
| sourceNamespace: openshift-marketplace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| apiVersion: performance.openshift.io/v1alpha1 | ||
| kind: PerformanceProfile | ||
| metadata: | ||
| name: performance | ||
| spec: | ||
| cpu: | ||
| isolated: "1-3" | ||
| nonIsolated: "0" | ||
| reserved: "0-1" | ||
| hugepages: | ||
| defaultHugepagesSize: "1G" | ||
| pages: | ||
| - size: "1G" | ||
| count: 1 | ||
| realTimeKernel: | ||
| enabled: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - ../../base/performance | ||
|
|
||
| patchesStrategicMerge: | ||
| - operator_catalogsource.patch.yaml | ||
| - performance_profile.patch.yaml |
7 changes: 7 additions & 0 deletions
7
feature-configs/demo/performance/operator_catalogsource.patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: operators.coreos.com/v1alpha1 | ||
| kind: CatalogSource | ||
| metadata: | ||
| name: performance-addon-operators-catalogsource | ||
| namespace: openshift-marketplace | ||
| spec: | ||
| image: quay.io/slintes/performance-addon-operators-registry |
7 changes: 7 additions & 0 deletions
7
feature-configs/demo/performance/performance_profile.patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: performance.openshift.io/v1alpha1 | ||
| kind: PerformanceProfile | ||
| metadata: | ||
| name: performance | ||
| spec: | ||
| nodeSelector: | ||
| node-role.kubernetes.io/worker-rt: "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - ../../base/performance | ||
|
|
||
| patchesStrategicMerge: | ||
| - operator_catalogsource.patch.yaml | ||
| - performance_profile.patch.yaml |
7 changes: 7 additions & 0 deletions
7
feature-configs/e2e-gcp/performance/operator_catalogsource.patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: operators.coreos.com/v1alpha1 | ||
| kind: CatalogSource | ||
| metadata: | ||
| name: performance-addon-operators-catalogsource | ||
| namespace: openshift-marketplace | ||
| spec: | ||
| image: quay.io/slintes/performance-addon-operators-registry |
7 changes: 7 additions & 0 deletions
7
feature-configs/e2e-gcp/performance/performance_profile.patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: performance.openshift.io/v1alpha1 | ||
| kind: PerformanceProfile | ||
| metadata: | ||
| name: performance | ||
| spec: | ||
| nodeSelector: | ||
| node-role.kubernetes.io/worker-rt: "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| # expect oc to be in PATH by default | ||
| export OC_TOOL="${OC_TOOL:-oc}" | ||
|
|
||
| # Label 1 worker node | ||
| echo "[INFO]: Labeling 1 worker node with worker-rt" | ||
| node=$(${OC_TOOL} get nodes --selector='node-role.kubernetes.io/worker' -o name | head -1) | ||
| ${OC_TOOL} label $node node-role.kubernetes.io/worker-rt="" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this logic can be better:
other then that, we can use a single oc apply -k, if we create a folder referencing all the wanted features.
which IMHO would be 'cleaner' than running multiple kustomize commands. we can even have an overlay dir with some supported/most relevant variations (all, networking, performance, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for review!
oc -k, see Added kustomization for performance #4 (comment)