🤖 Triggering CI on branch 'release-next' after syncing to upstream/main

[serverless-qe]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skonto]

	0s
{Failed  panic: test timed out after 10m0s
running tests:
	TestGRPCUnaryPing (10m0s)

[skonto]

/test 416-test-e2e-aws-416

[skonto]

@ReToCode do we patch anything related to that test? 🤔

[skonto]

It seems it fails in periodics too.

[ReToCode]

Not that I'm aware of. No idea 🤷

[skonto]

It seems quite deterministic.

[skonto]

It fails when it goes through OCP route:

04:47:02.150 SUCCESS: 🌟 Tests have passed 🌟
gRPC test via OCP
ingress.config.openshift.io/cluster annotated
knativeserving.operator.knative.dev/knative-serving annotated
knativeserving.operator.knative.dev/knative-serving patched

[skonto]

/test 416-test-e2e-aws-416

[skonto]

/test ?

[openshift-ci]

@skonto: The following commands are available to trigger required jobs:

• /test 413-images
• /test 413-test-e2e-aws-413
• /test 416-images
• /test 416-test-e2e-aws-416
• /test 417-images
• /test 417-test-e2e-aws-417

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-knative-serving-release-next-416-images
• pull-ci-openshift-knative-serving-release-next-416-test-e2e-aws-416

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[skonto]

/test 413-test-e2e-aws-413

[skonto]

/test 417-test-e2e-aws-417

[skonto]

/override ci/prow/417-test-e2e-aws-417

[openshift-ci]

@skonto: Overrode contexts on behalf of skonto: ci/prow/417-test-e2e-aws-417

In response to this:

/override ci/prow/417-test-e2e-aws-417

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[skonto]

/override ?

[openshift-ci]

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• ?

Only the following failed contexts/checkruns were expected:

• ci/prow/413-test-e2e-aws-413
• ci/prow/416-images
• ci/prow/416-test-e2e-aws-416
• ci/prow/417-test-e2e-aws-417
• pull-ci-openshift-knative-serving-release-next-413-test-e2e-aws-413
• pull-ci-openshift-knative-serving-release-next-416-images
• pull-ci-openshift-knative-serving-release-next-416-test-e2e-aws-416
• pull-ci-openshift-knative-serving-release-next-417-test-e2e-aws-417
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[skonto]

grpc 1.67.0 brings this change https://github.com/grpc/grpc-go/blob/bcf9171a20e44ed81a6eb152e3ca9e35b2c02c5d/credentials/tls.go#L129.
See grpc/grpc-go#7535. cc @ReToCode

[skonto]

@ReToCode
We have an edge terminated route and obviously alpn is empty. Haproxy has this: https://github.com/openshift/router/blob/master/images/router/haproxy/conf/haproxy-config.template#L739.
Setting appProtocol: h2c for the services would fix the issue 🤞 .

As a side note, we had a problem with appProtocol: kubernetes.io/h2c and mtls (thus we have a patch that reverts the upstream stuff), see https://issues.redhat.com/browse/SRVKS-1232. However I think the reason was that port name and appProtocol should have the same value thus the issue in SRVKS-1232, specifically check the issue and the validator code. I think we need to revise the work upstream in knative#14809 as it does not work with mesh and we don't test with mesh upstream.

Ideally we want to keep appProtocol: kubernetes.io/h2c and file a bug for the OCP router so the latter supports it, see discussion here.

Also we can't just set the following to false as it will be removed in future releases (maybe just for now):

	ALTSMaxConcurrentHandshakes = uint64FromEnv("GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES", 100, 1, 100)
	// EnforceALPNEnabled is set if TLS connections to servers with ALPN disabled
	// should be rejected. The HTTP/2 protocol requires ALPN to be enabled, this
	// option is present for backward compatibility. This option may be overridden
	// by setting the environment variable "GRPC_ENFORCE_ALPN_ENABLED" to "true"
	// or "false".
	EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", true)

[skonto]

Reverting passes see: #893.

[ReToCode]

Hm nice find. To be honest, no idea. Could we probably also just set GRPC_ENFORCE_ALPN_ENABLED? So we could keep the upstream changes?

[skonto]

Ok checking in #894. I will talk to router folks to open a bug as well. Going forward we need this, setting the env var is temporary unless we patch grpc itself and remove that alpn check (a bit ugly).

[openshift-ci]

@serverless-qe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/417-test-e2e-aws-417	2155411	link	true	/test 417-test-e2e-aws-417
ci/prow/413-test-e2e-aws-413	2155411	link	true	/test 413-test-e2e-aws-413

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ReToCode]

/retest

[skonto]

@ReToCode I suspect it does not get the fix, probably we will have to close it and wait for the next one?

[skonto]

Wait it seems the errors are not related.

The ImageStreamTag "ubi-minimal:latest" is invalid: from: Error resolving ImageStreamTag ubi-minimal:latest in namespace openshift-marketplace: unable to find latest tagged image

[serverless-qe]

OCF Webhook is merging this PR